Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: components/favicon_base/BUILD.gn

Issue 835903005: [Favicon] Add new fallback icon rendering flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing FallbackIconStyleBuilder; trimming down chrome://fallback-icon syntax. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon_base/BUILD.gn
diff --git a/components/favicon_base/BUILD.gn b/components/favicon_base/BUILD.gn
index 6e40b06718f9e7dad8a1a03aa53dd7474233afb0..856e045f843b499bdf683fdee7a1c3f64a3b458a 100644
--- a/components/favicon_base/BUILD.gn
+++ b/components/favicon_base/BUILD.gn
@@ -2,8 +2,12 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-source_set("favicon_base") {
+static_library("favicon_base") {
sources = [
+ "fallback_icon_service.cc",
+ "fallback_icon_service.h",
+ "fallback_icon_style.cc",
+ "fallback_icon_style.h",
pkotwicz 2015/01/23 16:00:48 I don't see fallback_icon_style.* in the diff
huangs 2015/01/23 19:47:52 Done.
"favicon_callback.h",
"favicon_types.cc",
"favicon_types.h",
@@ -20,3 +24,16 @@ source_set("favicon_base") {
"//url",
]
}
+
+source_set("unit_tests") {
+ sources = [
pkotwicz 2015/01/23 16:00:48 The unit test now longer exists, remove it
huangs 2015/01/23 19:47:52 Done.
+ "fallback_icon_style_unittest.cc",
+ ]
+
+ deps = [
+ ":favicon_base",
+ "//base",
+ "//base/test:test_support",
+ "//testing/gtest",
+ ]
+}

Powered by Google App Engine
This is Rietveld 408576698