[Favicon] Add new fallback icon rendering flow.

components/favicon_base/favicon_types.cc

Index: components/favicon_base/favicon_types.cc
diff --git a/components/favicon_base/favicon_types.cc b/components/favicon_base/favicon_types.cc
index eb0e7bcfa6b0a662720117c33c24ff5abd1b43de..1fb6dd389fb18362bf83d40db26b8150774db910 100644
--- a/components/favicon_base/favicon_types.cc
+++ b/components/favicon_base/favicon_types.cc
@@ -6,14 +6,15 @@
 
 namespace favicon_base {
 
-// FaviconImageResult ---------------------------------------------------------
+// ---------------------------------------------------------
+// FaviconImageResult
 
 FaviconImageResult::FaviconImageResult() {}
 
 FaviconImageResult::~FaviconImageResult() {}
 
-// FaviconRawBitmapResult
 // --------------------------------------------------------
+// FaviconRawBitmapResult
 
 FaviconRawBitmapResult::FaviconRawBitmapResult()
     : expired(false), icon_type(INVALID_ICON) {
@@ -22,4 +23,17 @@ FaviconRawBitmapResult::FaviconRawBitmapResult()
 FaviconRawBitmapResult::~FaviconRawBitmapResult() {
 }
 
-}  // namespace chrome
+// --------------------------------------------------------
+// FallbackIconStyle
+
+FallbackIconStyle::FallbackIconStyle()
+    : background_color(SK_ColorTRANSPARENT),
+      text_color(SK_ColorTRANSPARENT),
+      font_size_ratio(0.0),
+      roundness(0.0) {

[pkotwicz, 2015/01/21 19:44:16]

Can the constructor initialize FallbackIconStyle with the defaults?

[huangs, 2015/01/22 01:13:28]

The default text color depends on the background color: it's black for bright
background and white for dark background.  If we initialize other fields then
we'll have scattered default values.  Therefore I'm letting
FallbackIconStyleBuilder handle all the defaults, and just initialize them to
useless values in the constructor.

+}
+
+FallbackIconStyle::~FallbackIconStyle() {
+}
+
+}  // namespace favicon_base