Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 835903005: [Favicon] Add new fallback icon rendering flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding new host chrome://fallback-icon. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/webui/ntp/most_visited_handler.cc ('K') | « chrome/browser/ui/webui/ntp/suggestions_page_handler.cc ('k') | chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui.cc » ('j') | chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 7d1874c0c99ae63fbbe98925f6fdf3c00d6057f9..31fb57834a688276aa2cf8623550c270c994c560 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -59,6 +59,7 @@
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/chrome_select_file_policy.h"
#include "chrome/browser/ui/host_desktop.h"
+#include "chrome/browser/ui/webui/fallback_icon_source.h"
#include "chrome/browser/ui/webui/favicon_source.h"
#include "chrome/browser/ui/webui/options/options_handlers_helper.h"
#include "chrome/common/chrome_constants.h"
@@ -857,6 +858,8 @@ void BrowserOptionsHandler::InitializeHandler() {
if (signin_manager)
signin_observer_.Add(signin_manager);
pkotwicz 2015/01/21 19:44:15 Remove this too
huangs 2015/01/22 01:13:27 Done.
+ // Create our fallback icon data source.
+ content::URLDataSource::Add(profile, new FallbackIconSource());
// Create our favicon data source.
content::URLDataSource::Add(
profile, new FaviconSource(profile, FaviconSource::FAVICON));
« chrome/browser/ui/webui/ntp/most_visited_handler.cc ('K') | « chrome/browser/ui/webui/ntp/suggestions_page_handler.cc ('k') | chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui.cc » ('j') | chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698