Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2536)

Unified Diff: chrome/common/favicon/favicon_url_parser.h

Issue 835903005: [Favicon] Add new fallback icon rendering flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactor by extracting FallbackIconSpecsBuilder. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/favicon/favicon_url_parser.h
diff --git a/chrome/common/favicon/favicon_url_parser.h b/chrome/common/favicon/favicon_url_parser.h
index d7de77080a89e455c09ee6dbc8e18becba9fd981..e9c86b162cb3e9dce22e87aaff66e32c894f5b3d 100644
--- a/chrome/common/favicon/favicon_url_parser.h
+++ b/chrome/common/favicon/favicon_url_parser.h
@@ -5,8 +5,12 @@
#ifndef CHROME_COMMON_FAVICON_FAVICON_URL_PARSER_H_
#define CHROME_COMMON_FAVICON_FAVICON_URL_PARSER_H_
+#include <memory>
#include <string>
+#include "components/favicon_base/fallback_icon_specs_builder.h"
+#include "third_party/skia/include/core/SkColor.h"
+
namespace chrome {
struct ParsedFaviconPath {
@@ -22,6 +26,10 @@ struct ParsedFaviconPath {
// The device scale factor of the requested favicon.
float device_scale_factor;
+ // Specifications of fallback icon. This is nullptr if no fallback.
+ std::unique_ptr<favicon_base::FallbackIconSpecsBuilder>
+ fallback_specs_builder;
+
// The index of the first character (relative to the path) where the the URL
// from which the favicon is being requested is located.
size_t path_index;

Powered by Google App Engine
This is Rietveld 408576698