Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/favicon_base/BUILD.gn

Issue 835903005: [Favicon] Add new fallback icon rendering flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup and simplification. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/favicon/fallback_icon_url_parser_unittest.cc ('K') | « components/favicon_base.gypi ('k') | components/favicon_base/DEPS » ('j') | components/favicon_base/fallback_icon_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon_base/BUILD.gn
diff --git a/components/favicon_base/BUILD.gn b/components/favicon_base/BUILD.gn
index 6e40b06718f9e7dad8a1a03aa53dd7474233afb0..c34bde98c8af260511db15ef8ea14065f26e4ddf 100644
--- a/components/favicon_base/BUILD.gn
+++ b/components/favicon_base/BUILD.gn
@@ -2,8 +2,10 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-source_set("favicon_base") {
+static_library("favicon_base") {
sources = [
+ "fallback_icon_service.cc",
+ "fallback_icon_service.h",
"favicon_callback.h",
"favicon_types.cc",
"favicon_types.h",
« chrome/common/favicon/fallback_icon_url_parser_unittest.cc ('K') | « components/favicon_base.gypi ('k') | components/favicon_base/DEPS » ('j') | components/favicon_base/fallback_icon_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698