Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: components/favicon_base/BUILD.gn

Issue 835903005: [Favicon] Add new fallback icon rendering flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing FallbackIconStyleBuilder; trimming down chrome://fallback-icon syntax. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("favicon_base") { 5 static_library("favicon_base") {
6 sources = [ 6 sources = [
7 "fallback_icon_service.cc",
8 "fallback_icon_service.h",
9 "fallback_icon_style.cc",
10 "fallback_icon_style.h",
pkotwicz 2015/01/23 16:00:48 I don't see fallback_icon_style.* in the diff
huangs 2015/01/23 19:47:52 Done.
7 "favicon_callback.h", 11 "favicon_callback.h",
8 "favicon_types.cc", 12 "favicon_types.cc",
9 "favicon_types.h", 13 "favicon_types.h",
10 "favicon_util.cc", 14 "favicon_util.cc",
11 "favicon_util.h", 15 "favicon_util.h",
12 "select_favicon_frames.cc", 16 "select_favicon_frames.cc",
13 "select_favicon_frames.h", 17 "select_favicon_frames.h",
14 ] 18 ]
15 19
16 deps = [ 20 deps = [
17 "//base", 21 "//base",
18 "//skia", 22 "//skia",
19 "//ui/gfx", 23 "//ui/gfx",
20 "//url", 24 "//url",
21 ] 25 ]
22 } 26 }
27
28 source_set("unit_tests") {
29 sources = [
pkotwicz 2015/01/23 16:00:48 The unit test now longer exists, remove it
huangs 2015/01/23 19:47:52 Done.
30 "fallback_icon_style_unittest.cc",
31 ]
32
33 deps = [
34 ":favicon_base",
35 "//base",
36 "//base/test:test_support",
37 "//testing/gtest",
38 ]
39 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698