[Favicon] Add new fallback icon rendering flow.

components/favicon_base/favicon_types.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_FAVICON_BASE_FAVICON_TYPES_H_
 #define COMPONENTS_FAVICON_BASE_FAVICON_TYPES_H_
 
 #include "base/memory/ref_counted_memory.h"
+#include "ui/gfx/color_utils.h"

[pkotwicz, 2015/01/21 19:44:16]

Nit: Please include "third_party/skia/include/core/SkColor.h"

Why are you including "ui/gfx/color_utils.h"?

[huangs, 2015/01/22 01:13:28]

Done.

 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/image/image.h"
 #include "url/gurl.h"
 
 namespace favicon_base {
 
 typedef int64 FaviconID;
 
 // Defines the icon types. They are also stored in icon_type field of favicons
 // table.
@@ skipping 46 matching lines @@
   GURL icon_url;
 
   // The icon type of the containing favicon.
   IconType icon_type;
 };
 
 // Define type with same structure as FaviconRawBitmapResult for passing data to
 // HistoryBackend::SetFavicons().
 typedef FaviconRawBitmapResult FaviconRawBitmapData;
 
+// Styling specifications of a fallback icon. These icons are square, and
+// consist of a solid rounded rectangle containing a single letter. Styles
+// excludes icon URL and size, since these are only specified when we render.

[pkotwicz, 2015/01/21 19:44:16]

How about: "Specification for a fallback icon. The icon is composed of a solid
rounded square containing a single letter. The specification excludes the icon
URL which is specified when the icon is rendered."

No reason to exclude the size :)

[huangs, 2015/01/22 01:13:28]

Rephrased, but kept size excluded still.

+struct FallbackIconStyle {
+  FallbackIconStyle();
+  ~FallbackIconStyle();
+
+  // Icon background fill color.
+  SkColor background_color;
+
+  // Icon text color.
+  SkColor text_color;
+
+  // Ratio in [0.0, 1.0] from text font size (pixels) to icon size.

[pkotwicz, 2015/01/21 19:44:16]

Nits: "from text font size" -> "of the text font size"
      "to icon size" -> "to the icon size"

[huangs, 2015/01/22 01:13:28]

Done.

+  double font_size_ratio;
+
+  // Ratio in [0.0, 1.0] to adjust rounded square's corner radius. The scale is
+  // adjusted so 0.0 => square and 0.5 => circle.

[pkotwicz, 2015/01/21 19:44:16]

How about: "The roundness of the icon's corners. 0.0 => square icon, 1.0 =>
circle icon.

[huangs, 2015/01/22 01:13:28]

Done.

+  double roundness;
+
+  // If any member change, also update FallbackIconStyleBuilder.

[pkotwicz, 2015/01/21 19:44:16]

Nit: change -> changes

[huangs, 2015/01/22 01:13:28]

Done.

+};
+
 }  // namespace favicon_base
 
 #endif  // COMPONENTS_FAVICON_BASE_FAVICON_TYPES_H_