Add script to generate the v8 version.

Add script to generate the v8 version.

BUG=chromium:446166
LOG=n
TBR=jkummerow@chromium.org
NOTRY=true

Committed: https://crrev.com/d09361ba946d547155ef84b211d101f91ebee090
Cr-Commit-Position: refs/heads/master@{#25964}

[Michael Achenbach, 2015-01-05 14:04:20]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org

[Michael Achenbach, 2015-01-05 14:05:50]

PTAL. Code could be more pythonish. The most important thing is that this code
works on all our supported compilation platforms (e.g. windows). Not sure if it
does.

[tandrii_google, 2015-01-05 14:46:08]

tandrii@google.com changed reviewers:
+ tandrii@google.com

[tandrii_google, 2015-01-05 14:46:09]

lgtm

the only non-pythonic (sort of) thing I see is the capitalization of free
functions.

https://codereview.chromium.org/835903003/diff/20001/tools/push-to-trunk/gene...
File tools/push-to-trunk/generate_version.py (right):

https://codereview.chromium.org/835903003/diff/20001/tools/push-to-trunk/gene...
tools/push-to-trunk/generate_version.py:21: def Main():
nit: why capitalized?

https://codereview.chromium.org/835903003/diff/20001/tools/push-to-trunk/gene...
tools/push-to-trunk/generate_version.py:53: with open(VERSION_CC, "r") as f:
yes, this "with" statement is important on Windows, as file *must* be closed
before overwriting.

https://codereview.chromium.org/835903003/diff/20001/tools/push-to-trunk/gene...
tools/push-to-trunk/generate_version.py:55: def Sub(line, definition,
substitute):
i wouldn't make this a function

[Michael Achenbach, 2015-01-07 08:46:40]

Done

[Michael Achenbach, 2015-01-07 08:48:14]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-01-07 08:48:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/835903003/40001

[commit-bot: I haz the power, 2015-01-07 08:48:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-07 08:48:28]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Michael Achenbach, 2015-01-07 08:51:43]

machenbach@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Michael Achenbach, 2015-01-07 08:51:47]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-01-07 08:52:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/835903003/40001

[commit-bot: I haz the power, 2015-01-07 08:52:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-07 08:52:49]

Patchset 3 (id:??) landed as
https://crrev.com/d09361ba946d547155ef84b211d101f91ebee090
Cr-Commit-Position: refs/heads/master@{#25964}

[Jakob Kummerow, 2015-01-07 09:18:22]

LGTM

On 2015/01/05 14:46:09, tandrii_google wrote:
> the only non-pythonic (sort of) thing I see is the capitalization of free
> functions.

Since most code in V8 is C++, we tend to apply the C++ style guide's formatting
rules to scripts written in other languages. Personally, I'm happy with this,
because I think consistency within a project is more valuable than consistency
with other projects using the same language.

https://codereview.chromium.org/835903003/diff/40001/tools/push-to-trunk/gene...
File tools/push-to-trunk/generate_version.py (right):

https://codereview.chromium.org/835903003/diff/40001/tools/push-to-trunk/gene...
tools/push-to-trunk/generate_version.py:54: text = f.read()
More pythonification:

with open(VERSION_CC, "r") as f:
  for line in f:
    ...

Note that with the above, |line| will still have a trailing '\n'.