Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(481)

Issue 8359027: Update the Valgrind binaries for Mac and Linux to valgrind-variant r106 (Closed)

Created:
9 years ago by Alexander Potapenko
Modified:
9 years ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews
Visibility:
Public.

Description

Update the Valgrind binaries for Mac and Linux to valgrind-variant r106 TBR=timurrrr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M binaries/linux_x64/bin/valgrind View Binary file 0 comments Download
M binaries/linux_x64/lib/valgrind/memcheck-amd64-linux View Binary file 0 comments Download
M binaries/linux_x64/lib/valgrind/memcheck-x86-linux View Binary file 0 comments Download
M binaries/linux_x86/bin/valgrind View Binary file 0 comments Download
M binaries/linux_x86/lib/valgrind/memcheck-x86-linux View Binary file 0 comments Download
M binaries/mac_10.6/bin/no_op_client_for_valgrind View Binary file 0 comments Download
M binaries/mac_10.6/bin/valgrind View Binary file 0 comments Download
M binaries/mac_10.6/bin/valgrind-listener View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/default.supp View 1 chunk +9 lines, -0 lines 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-x86-darwin.so View Binary file 0 comments Download
binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so View 0 chunks +-1 lines, --1 lines 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-x86-darwin.so View Binary file 0 comments Download
M scripts/build-memcheck-for-chromium.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexander Potapenko
TBR
9 years ago (2011-10-21 12:08:52 UTC) #1
Timur Iskhodzhanov
9 years ago (2011-10-21 12:17:22 UTC) #2
You've missed the 10.5 part.
Linux + 10.6 -> LGTM

On Fri, Oct 21, 2011 at 4:08 PM,  <glider@chromium.org> wrote:
> Reviewers: Timur Iskhodzhanov,
>
> Message:
> TBR
>
> Description:
> Update the Valgrind binaries for Mac and Linux to valgrind-variant r106
>
> TBR=timurrrr
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106704
>
> Please review this at http://codereview.chromium.org/8359027/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/
>
> Affected files:
>  M     README.chromium
>  M     binaries/linux_x64/bin/valgrind
>  M     binaries/linux_x64/lib/valgrind/memcheck-amd64-linux
>  M     binaries/linux_x64/lib/valgrind/memcheck-x86-linux
>  M     binaries/linux_x86/bin/valgrind
>  M     binaries/linux_x86/lib/valgrind/memcheck-x86-linux
>  M     binaries/mac_10.6/bin/no_op_client_for_valgrind
>  M     binaries/mac_10.6/bin/valgrind
>  M     binaries/mac_10.6/bin/valgrind-listener
>  M     binaries/mac_10.6/lib/valgrind/default.supp
>  M     binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so
>  M
>
binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-amd64-darwin.so
>  M     binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so
>  M
>
binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-x86-darwin.so
>  M     binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin
>  M
>
binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin
>  M     binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin
>  M
>
binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin
>  M     binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so
>  M
>
binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-amd64-darwin.so
>  M     binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so
>  M
>
binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-x86-darwin.so
>  binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so
>  M
>
binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-amd64-darwin.so
>  M     binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so
>  M
>
binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-x86-darwin.so
>  M     scripts/build-memcheck-for-chromium.sh
>
>
> Index: README.chromium
> ===================================================================
> --- README.chromium     (revision 106486)
> +++ README.chromium     (working copy)
> @@ -1,8 +1,8 @@
>  Name: valgrind
>  Version: unknown
>
> -Memcheck version on Linux (valgrind-variant): 102
> -Memcheck version on Mac (valgrind-variant): unknown
> +Memcheck version on Linux (valgrind-variant): 106
> +Memcheck version on Mac (valgrind-variant): 106
>
>  TSan version on Linux: unknown
>  TSan version on Mac: unknown
> Index: binaries/linux_x64/bin/valgrind
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x64/lib/valgrind/memcheck-amd64-linux
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x64/lib/valgrind/memcheck-x86-linux
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x86/bin/valgrind
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x86/lib/valgrind/memcheck-x86-linux
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac_10.6/bin/no_op_client_for_valgrind
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac_10.6/bin/valgrind
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac_10.6/bin/valgrind-listener
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac_10.6/lib/valgrind/default.supp
> ===================================================================
> --- binaries/mac_10.6/lib/valgrind/default.supp (revision 106486)
> +++ binaries/mac_10.6/lib/valgrind/default.supp (working copy)
> @@ -681,3 +681,12 @@
>    fun:_ZN13TFontFeaturesC2EP6CGFont
>    fun:_ZNK9TBaseFont12CopyFeaturesEv
>  }
> +
> +# See https://bugs.kde.org/show_bug.cgi?id=188572 about this;  it's
> +# unavoidable due to BSD setenv() semantics.
> +{
> +   macos-__setenv-leak-see-our-bug-188572
> +   Memcheck:Leak
> +   fun:malloc_zone_malloc
> +   fun:__setenv
> +}
> Index: binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-amd64-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-amd64-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-amd64-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index:
>
binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-x86-darwin.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: scripts/build-memcheck-for-chromium.sh
> ===================================================================
> --- scripts/build-memcheck-for-chromium.sh      (revision 106486)
> +++ scripts/build-memcheck-for-chromium.sh      (working copy)
> @@ -10,7 +10,7 @@
>
>  # SVN isn't smart enough to figure out what rev of VEX to get,
>  # so you have to check that out by revision.
> -MEMCHECK_VV_REV=102
> +MEMCHECK_VV_REV=106
>
>  VG_MEMCHECK_DIR="$VG_SRC_DIR/valgrind-memcheck"
>  checkout_and_patch_valgrind_variant "$MEMCHECK_VV_REV" "$VG_MEMCHECK_DIR"
>
>
>

Powered by Google App Engine
This is Rietveld 408576698