Issue 8359010: Convert the Flash interfaces to no longer use GetInfo.

Issue 8359010: Convert the Flash interfaces to no longer use GetInfo. (Closed)

Created:
9 years, 2 months ago by brettw

Modified:
9 years, 2 months ago

Reviewers:
yzshen1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Convert the Flash interfaces to no longer use GetInfo. GetInfo is deprecated. I moved all the Flash setup for the proxy into a separate function since I suspect we'll be moving this somewhere else in the future to allow a non-Flash build of the proxy. I didn't change any thunk stuff (it would be nice to convert more of these APIs) since I started and this patch got too complicated. I also changed the way the factory functions worked. I could save a bunch of macros by using a template. Yay! TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106856

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review comment #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -145 lines)			Patch
M	ppapi/proxy/interface_list.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	ppapi/proxy/interface_list.cc	View		4 chunks	+51 lines, -24 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_clipboard_proxy.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_flash_clipboard_proxy.cc	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_file_proxy.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_file_proxy.cc	View		2 chunks	+5 lines, -18 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_menu_proxy.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_menu_proxy.cc	View	1	3 chunks	+0 lines, -21 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_net_connector_proxy.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_net_connector_proxy.cc	View	1	2 chunks	+0 lines, -20 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_proxy.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_flash_proxy.cc	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_tcp_socket_proxy.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_tcp_socket_proxy.cc	View	1	2 chunks	+0 lines, -16 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_udp_socket_proxy.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_udp_socket_proxy.cc	View	1	2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

I already have some reviews waiting on Trung, so I'm removing him.

9 years, 2 months ago (2011-10-20 23:12:44 UTC) #2

yzshen1

9 years, 2 months ago (2011-10-21 04:04:06 UTC) #3

LGTM

Thanks!

http://codereview.chromium.org/8359010/diff/1/ppapi/proxy/ppb_flash_menu_prox...
File ppapi/proxy/ppb_flash_menu_proxy.cc (right):

http://codereview.chromium.org/8359010/diff/1/ppapi/proxy/ppb_flash_menu_prox...
ppapi/proxy/ppb_flash_menu_proxy.cc:14: #include "ppapi/thunk/thunk.h"
You may not need this include any more. (Some other files don't need this
include, either.)

Expand Messages | Collapse Messages