runtime/vm/regexp_assembler.cc - Issue 835843004: Eliminate bounds checks on fixed-length registers array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/regexp_assembler.cc

Issue 835843004: Eliminate bounds checks on fixed-length registers array. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/regexp_assembler.cc

diff --git a/runtime/vm/regexp_assembler.cc b/runtime/vm/regexp_assembler.cc

index c1d5d510c17feadd078f3c8764db29dc8292abab..4a2fed2b7f93b2dd3b80b529a14357286c94a715 100644

--- a/runtime/vm/regexp_assembler.cc

+++ b/runtime/vm/regexp_assembler.cc

@@ -199,7 +199,11 @@ void IRRegExpMacroAssembler::GenerateEntryBlock() {

// Generate a local list variable to represent the backtracking stack.

StoreLocal(stack_, Bind(new(I) ConstantInstr(stack_array_)));

PushArgumentInstr* stack_push = PushLocal(stack_);

- Do(InstanceCall(InstanceCallDescriptor(Symbols::clear()), stack_push));

+ PushArgumentInstr* zero_push = PushArgument(Bind(Uint64Constant(0)));

+ Do(InstanceCall(InstanceCallDescriptor(

+ Library::PrivateCoreLibName(Symbols::_setLength())),

+ stack_push,

+ zero_push));

// Jump to the start block.

current_instruction_->Goto(start_block_);

« no previous file with comments | « runtime/vm/constant_propagator.cc ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »