Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 83583003: MIPS: Fix and simplify code aging. (Closed)

Created:
7 years, 1 month ago by palfia
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix and simplify code aging. This commit fixes a lot of test failures that we saw earlier in the buildbots (http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20mips%20-%20sim/builds/3034/steps/Check/logs/stdio). In some very rare cases the code age stub address can be 0xXXXX0000 and in this case the li maco instruction emits only 1 instruction (instead of the expected 2). Thus the code age sequence will be 6 instructions long instead of 7, which breaks the code aging feature. This change makes sure that li always emits 2 instructions and it also simplifies the code aging sequence. Also fixes a small mistake in the simulator at the jalr instruction. BUG= R=gergely@homejinni.com Committed: https://code.google.com/p/v8/source/detail?r=18030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -34 lines) Patch
M src/mips/assembler-mips-inl.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/mips/codegen-mips.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M src/mips/simulator-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/simulator-mips.cc View 5 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
palfia
PTAL.
7 years, 1 month ago (2013-11-22 16:15:26 UTC) #1
dusmil
Looks Good To Me.
7 years, 1 month ago (2013-11-22 17:17:48 UTC) #2
kisg
LGTM
7 years, 1 month ago (2013-11-22 17:52:26 UTC) #3
palfia
7 years, 1 month ago (2013-11-22 18:14:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18030 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698