Clean up dead clear() code in SkRecord.

Clean up dead clear() code in SkRecord.

This removes the SkRecords::Clear struct and everything that refers to it.
Notice there is nothing actually creating a Clear, which means this is all
dead code.

Now that all ops obey the clip, I don't think we need the weird
inflate-empty-to-epsilon hack for BBH queries.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/49aabde6ef80e39f00a2d00487cf5a881987dd81

[mtklein, 2015-01-04 15:18:31]

mtklein@google.com changed reviewers:
+ mtklein@google.com, reed@google.com, robertphillips@google.com

[mtklein, 2015-01-04 15:18:31]

First review wins.

[mtklein, 2015-01-04 15:18:34]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-01-04 15:19:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/835813002/1

[commit-bot: I haz the power, 2015-01-04 15:19:28]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-01-04 21:19 UTC

[mtklein, 2015-01-04 15:23:56]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-01-04 15:23:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/835813002/20001

[commit-bot: I haz the power, 2015-01-04 15:23:58]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-01-04 21:23 UTC

[commit-bot: I haz the power, 2015-01-04 21:23:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-04 21:23:59]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[reed1, 2015-01-05 14:45:30]

https://codereview.chromium.org/835813002/diff/20001/src/core/SkRecordDraw.cpp
File src/core/SkRecordDraw.cpp (right):

https://codereview.chromium.org/835813002/diff/20001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:28: (void)canvas->getClipBounds(&query);
not sure why the new form is clearer.

[reed1, 2015-01-05 14:45:35]

lgtm

[mtklein, 2015-01-05 14:49:17]

https://codereview.chromium.org/835813002/diff/20001/src/core/SkRecordDraw.cpp
File src/core/SkRecordDraw.cpp (right):

https://codereview.chromium.org/835813002/diff/20001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:28: (void)canvas->getClipBounds(&query);
On 2015/01/05 14:45:30, reed1 wrote:
> not sure why the new form is clearer.

You're saying you prefer
  SkRect query;
  if (!canvas->getClipBounds(&query)) {
    query.setEmpty();
  }
?  That'd be fine with me.

[mtklein, 2015-01-05 14:54:04]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-01-05 14:54:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/835813002/40001

[commit-bot: I haz the power, 2015-01-05 15:02:49]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/49aabde6ef80e39f00a2d00487cf5a881987dd81

[reed1, 2015-01-05 16:26:08]

https://codereview.chromium.org/835813002/diff/20001/src/core/SkRecordDraw.cpp
File src/core/SkRecordDraw.cpp (right):

https://codereview.chromium.org/835813002/diff/20001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:28: (void)canvas->getClipBounds(&query);
On 2015/01/05 14:49:17, mtklein wrote:
> On 2015/01/05 14:45:30, reed1 wrote:
> > not sure why the new form is clearer.
> 
> You're saying you prefer
>   SkRect query;
>   if (!canvas->getClipBounds(&query)) {
>     query.setEmpty();
>   }
> ?  That'd be fine with me.

danke