Show suggest apps dialog also in Download.

ui/file_manager/file_manager/foreground/js/task_controller.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @param {DialogType} dialogType
  * @param {!FileManagerUI} ui
  * @param {!MetadataCache} metadataCache
  * @param {!FileSelectionHandler} selectionHandler
  * @param {!MetadataUpdateController} metadataUpdateController
@@ skipping 194 matching lines @@
  * Opens the suggest file dialog.
  *
  * @param {Entry} entry Entry of the file.
  * @param {function()} onSuccess Success callback.
  * @param {function()} onCancelled User-cancelled callback.
  * @param {function()} onFailure Failure callback.
  * @private
  */
 TaskController.prototype.openSuggestAppsDialog =
     function(entry, onSuccess, onCancelled, onFailure) {
-  if (!url) {
+  if (!entry) {
     onFailure();
     return;
   }
 
-  this.metadataCache_.getOne(entry, 'external', function(prop) {
-    if (!prop || !prop.contentMimeType) {
+  this.getMimeType_(entry).then(function(mimeType) {
+    var basename = entry.name;
+    var splitted = util.splitExtension(basename);
+    var extension = splitted[1];
+
+    // Returns with failure if the file has neither extension nor MIME type.
+    if (!extension || !mimeType) {
       onFailure();
       return;
     }
-
-    var basename = entry.name;
-    var splitted = util.splitExtension(basename);
-    var filename = splitted[0];
-    var extension = splitted[1];
-    var mime = prop.contentMimeType;
-
-    // Returns with failure if the file has neither extension nor mime.
-    if (!extension || !mime) {
-      onFailure();
-      return;
-    }
 
     var onDialogClosed = function(result) {
       switch (result) {
         case SuggestAppsDialog.Result.INSTALL_SUCCESSFUL:
           onSuccess();
           break;
         case SuggestAppsDialog.Result.FAILED:
           onFailure();
           break;
         default:
           onCancelled();
       }
     };
 
-    if (FileTasks.EXECUTABLE_EXTENSIONS.indexOf(extension) !== -1) {
-      this.ui_.suggestAppsDialog.showByFilename(filename, onDialogClosed);
-    } else {
-      this.ui_.suggestAppsDialog.showByExtensionAndMime(
-          extension, mime, onDialogClosed);
-    }
+    this.ui_.suggestAppsDialog.showByExtensionAndMime(

[fukino, 2015/01/20 04:45:03]

showByFilename() is not in use now? If so, please remove the method. Maybe
SUGGEST_DIALOG_MESSAGE_FOR_EXECUTABLE can be removed, too.

[yawano, 2015/01/20 08:48:24]

showByFilename is removed with the patch set 1. Removed unused
SUGGEST_DIALOG_MESSAGE_FOR_EXECUTABLE with the new patch set.

+        extension, mimeType, onDialogClosed);
   }.bind(this));
 };
 
 /**
+ * Get MIME type for an entry. This method first tries to obtain the MIME type
+ * from metadata. If it fails, this falls back to obtain the MIME type from its
+ * content or name.
+ *
+ * @param {Entry} entry An entry to obtain its mime type.
+ * @return {!Promise}
+ * @private
+ */
+TaskController.prototype.getMimeType_ = function(entry) {
+  return new Promise(function(resolve, reject) {
+    this.metadataCache_.getOne(entry, 'external', function(prop) {
+      if (prop && prop.contentMimeType)
+        resolve(prop.contentMimeType);
+      else
+        chrome.fileManagerPrivate.getMimeType(entry.toURL(), resolve);
+    });
+  }.bind(this));
+}
+
+/**
  * Handles change of selection and clears context menu.
  * @private
  */
 TaskController.prototype.onSelectionChanged_ = function() {
   var selection = this.selectionHandler_.selection;
   // Caller of update context menu action items.
   // FileSelectionHandler.EventType.CHANGE
   if (this.dialogType_ === DialogType.FULL_PAGE &&
       selection.directoryCount === 0 && selection.fileCount > 0) {
     // Show disabled items for position calculation of the menu. They will be
@@ skipping 80 matching lines @@
       tasks.executeDefault();
     }.bind(this));
   } else {
     var selection = this.selectionHandler_.selection;
     if (selection.entries.length === 1 &&
         util.isSameEntry(selection.entries[0], entry)) {
       this.ui_.dialogFooter.okButton.click();
     }
   }
 };