Implement ES6 Array.prototype.toString behind --harmony-tostring

src/harmony-tostring.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 "use strict";
 
 // This file relies on the fact that the following declaration has been made
 // in runtime.js and symbol.js:
 // var $Object = global.Object;
 // var $Symbol = global.Symbol;
@@ skipping 15 matching lines @@
 // ES6 draft 08-24-14, section 19.1.3.6
 function ObjectToStringHarmony() {
   if (IS_UNDEFINED(this) && !IS_UNDETECTABLE(this)) return "[object Undefined]";
   if (IS_NULL(this)) return "[object Null]";
   var O = ToObject(this);
   var builtinTag = %_ClassOf(O);
   var tag = O[symbolToStringTag];
   if (IS_UNDEFINED(tag)) {
     tag = builtinTag;
   } else if (!IS_STRING(tag)) {
-    return "[object ???]"
+    return "[object ???]";
   } else if (tag !== builtinTag && kBuiltinStringTags[tag]) {
     return "[object ~" + tag + "]";
   }
   return "[object " + tag + "]";
 }
 
+// ES6 draft 12-06-14, section 22.1.3.27
+function ArrayToStringHarmony() {
+  if (IS_ARRAY(this) && this.join === ArrayJoin) {

[arv (Not doing code reviews), 2015/01/12 15:46:40]

It looks like we are doing Get(object, 'join') twice?

+    return Join(this, this.length, ',', ConvertToString);
+  }
+
+  var O = ToObject(this);
+  var join = O.join;
+  if (IS_SPEC_FUNCTION(join)) return %_CallFunction(O, join);
+  return %_CallFunction(O, ObjectToStringHarmony);

[arv (Not doing code reviews), 2015/01/12 15:46:40]

Could we just change ArrayToString to use DefaultObjectToString instead of
duplicating ArrayToString?

[caitp (gmail), 2015/01/12 15:53:16]

hmm, that's a good point

+}
+
 function HarmonyToStringExtendSymbolPrototype() {
   %CheckIsBootstrapping();
 
   InstallConstants($Symbol, $Array(
     // TODO(dslomov, caitp): Move to symbol.js when shipping
    "toStringTag", symbolToStringTag
   ));
 }
 
 HarmonyToStringExtendSymbolPrototype();
@@ skipping 10 matching lines @@
   // Set up the non-enumerable functions on the Array prototype object.
   var desc = ToPropertyDescriptor({
     value: ObjectToStringHarmony
   });
   DefineOwnProperty($Object.prototype, "toString", desc, false);
 
   %ToFastProperties($Object.prototype);
 }
 
 HarmonyToStringExtendObjectPrototype();
+
+function HarmonyToStringExtendArrayPrototype() {
+  %CheckIsBootstrapping();
+
+  // Can't use InstallFunctions() because will fail in Debug mode.
+  // Emulate InstallFunctions here.
+  %FunctionSetName(ArrayToStringHarmony, "toString");
+  %FunctionRemovePrototype(ArrayToStringHarmony);
+  %SetNativeFlag(ArrayToStringHarmony);
+
+  // Set up the non-enumerable functions on the Array prototype object.
+  var desc = ToPropertyDescriptor({
+    value: ArrayToStringHarmony
+  });
+  DefineOwnProperty($Array.prototype, "toString", desc, false);

[arv (Not doing code reviews), 2015/01/12 15:46:40]

DefineOwnProperty takes a descriptor... can we use a lower level API (above too)
that does not require that temporary descriptor object?

[caitp (gmail), 2015/01/12 15:53:16]

Sort of --- Runtime_AddOwnProperty (used by InstallFunctions) will throw if the
property already exists (in debug mode only).

There's a `RUNTIME_ASSERT(!it.IsFound());` in there which causes that, I'm not
sure if it's a good idea to remove it

+
+  %ToFastProperties($Array.prototype);
+}
+
+HarmonyToStringExtendArrayPrototype();