src/checks.cc - Issue 83573003: Best effort for C stack traces with unrecognised symbol format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/checks.cc

Issue 83573003: Best effort for C stack traces with unrecognised symbol format Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/checks.cc

diff --git a/src/checks.cc b/src/checks.cc

index a4514bf965094891cfb371ea46c05a6b1d26f05d..a1e450d0a71f012394a930422381b1907d518662 100644

--- a/src/checks.cc

+++ b/src/checks.cc

@@ -59,7 +59,7 @@ static V8_INLINE void DumpBacktrace() {

i::OS::PrintError("%s\n", demangled != NULL ? demangled : mangled);

free(demangled);

} else {

- i::OS::PrintError("??\n");

+ i::OS::PrintError("%s\n", symbols[i]);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »