Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: Source/modules/serviceworkers/NavigatorServiceWorker.h

Issue 835673006: Use caller's document url to resolve scriptURL/patternURL in registerServiceWorker/getRegistration (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/NavigatorServiceWorker.h
diff --git a/Source/modules/serviceworkers/NavigatorServiceWorker.h b/Source/modules/serviceworkers/NavigatorServiceWorker.h
index 39e21b32ce6532964587a0a93c9212c786ff683e..e70f77be2b046f9d1c09dfb5752cdb6a7d30cbb5 100644
--- a/Source/modules/serviceworkers/NavigatorServiceWorker.h
+++ b/Source/modules/serviceworkers/NavigatorServiceWorker.h
@@ -13,6 +13,7 @@ namespace blink {
class Document;
class Navigator;
+class DOMWindow;
class ServiceWorkerContainer;
class NavigatorServiceWorker final : public NoBaseWillBeGarbageCollected<NavigatorServiceWorker>, public WillBeHeapSupplement<Navigator>, DOMWindowProperty {
@@ -36,6 +37,7 @@ private:
virtual void willDetachGlobalObjectFromFrame() override;
PersistentWillBeMember<ServiceWorkerContainer> m_serviceWorker;
+ RefPtrWillBeMember<DOMWindow> m_domWindow;
dominicc (has gone to gerrit) 2015/01/19 03:19:08 Could this cause a leak by creating a cycle includ
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698