Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 835663002: [turbofan] Cache common Loop, Merge and Parameter operators. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Cache common Loop, Merge and Parameter operators. R=jarin@chromium.org BUG=v8:3792 LOG=n Committed: https://crrev.com/26fce420dadfb8cd74289f31bfaeb36806f2386e Cr-Commit-Position: refs/heads/master@{#25952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -12 lines) Patch
M src/compiler/common-operator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/common-operator.cc View 4 chunks +106 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-02 13:18:47 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-02 13:20:17 UTC) #2
Jarin
My eyes! How do I unsee this combination of higher-order macros and templates? I understand ...
5 years, 11 months ago (2015-01-02 13:52:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835663002/1
5 years, 11 months ago (2015-01-02 13:53:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-02 14:16:50 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-02 14:17:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26fce420dadfb8cd74289f31bfaeb36806f2386e
Cr-Commit-Position: refs/heads/master@{#25952}

Powered by Google App Engine
This is Rietveld 408576698