Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: base/strings/stringprintf_unittest.cc

Issue 835633003: Enable libc++ on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to friending fixes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/strings/stringprintf_unittest.cc
diff --git a/base/strings/stringprintf_unittest.cc b/base/strings/stringprintf_unittest.cc
index 321747869a076415232d16884c3198cf688c35e7..9a09a18244223a44b60411d6c11344f603749ea5 100644
--- a/base/strings/stringprintf_unittest.cc
+++ b/base/strings/stringprintf_unittest.cc
@@ -163,6 +163,8 @@ TEST(StringPrintfTest, Invalid) {
}
#endif
+// TODO(fdegans): Fix positional parameters, or remove test entirely.
Fabrice (no longer in Chrome) 2015/02/04 13:24:22 Nit: I now realize this message is not entirely he
jdduke (slow) 2015/02/05 18:37:15 Looks like this will go away completely, will reba
+#if !defined(OS_ANDROID)
// Test that the positional parameters work.
TEST(StringPrintfTest, PositionalParameters) {
std::string out;
@@ -175,6 +177,7 @@ TEST(StringPrintfTest, PositionalParameters) {
EXPECT_STREQ(L"test test", wout.c_str());
#endif
}
+#endif
// Test that StringPrintf and StringAppendV do not change errno.
TEST(StringPrintfTest, StringPrintfErrno) {

Powered by Google App Engine
This is Rietveld 408576698