Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: net/base/address_tracker_linux_unittest.cc

Issue 835633003: Enable libc++ on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Really fix AOSP Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/address_tracker_linux_unittest.cc
diff --git a/net/base/address_tracker_linux_unittest.cc b/net/base/address_tracker_linux_unittest.cc
index 641220731b71bbbe43b54f4e8b564921494f5b64..e74ce0596d93d4cae939a4d2cbfb7444b132c515 100644
--- a/net/base/address_tracker_linux_unittest.cc
+++ b/net/base/address_tracker_linux_unittest.cc
@@ -122,7 +122,10 @@ class NetlinkMessage {
void AppendTo(Buffer* output) const {
CHECK_EQ(NLMSG_ALIGN(output->size()), output->size());
output->reserve(output->size() + NLMSG_LENGTH(buffer_.size()));
- output->insert(output->end(), buffer_.begin(), buffer_.end());
+ // TODO(jdduke): Use proper iterators during insertion after resolution of
+ // GCC + libc++ friending issues on Android.
Nico 2015/01/29 22:51:33 Is this still needed? I thought aosp keeps using s
jdduke (slow) 2015/01/29 22:56:37 Do you know when the fix rolled/landed? I tried re
+ output->insert(output->end(), buffer_.data(),
+ buffer_.data() + buffer_.size());
}
private:

Powered by Google App Engine
This is Rietveld 408576698