Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2652)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/strings/stringprintf_unittest.cc

Issue 835633003: Enable libc++ on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Really fix AOSP Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/strings/string_util.cc ('k') | build/android/setup.gyp » ('j') | net/base/address_tracker_linux_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/strings/stringprintf_unittest.cc
diff --git a/base/strings/stringprintf_unittest.cc b/base/strings/stringprintf_unittest.cc
index 321747869a076415232d16884c3198cf688c35e7..7188470462e1cae7554eac7a1e39bdc93760806a 100644
--- a/base/strings/stringprintf_unittest.cc
+++ b/base/strings/stringprintf_unittest.cc
@@ -163,6 +163,8 @@ TEST(StringPrintfTest, Invalid) {
}
#endif
+// TODO(fdegans): fix positional parameters
+#if !defined(OS_ANDROID)
// Test that the positional parameters work.
TEST(StringPrintfTest, PositionalParameters) {
std::string out;
@@ -175,6 +177,7 @@ TEST(StringPrintfTest, PositionalParameters) {
EXPECT_STREQ(L"test test", wout.c_str());
#endif
}
+#endif
// Test that StringPrintf and StringAppendV do not change errno.
TEST(StringPrintfTest, StringPrintfErrno) {
« no previous file with comments | « base/strings/string_util.cc ('k') | build/android/setup.gyp » ('j') | net/base/address_tracker_linux_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698