Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 835593002: enable conics gm (Closed)

Created:
5 years, 11 months ago by reed2
Modified:
5 years, 11 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -50 lines) Patch
M gm/conicpaths.cpp View 1 3 chunks +21 lines, -40 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFUtils.cpp View 1 2 3 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835593002/1
5 years, 11 months ago (2015-01-01 04:08:58 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-01 04:08:58 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1368)
5 years, 11 months ago (2015-01-01 04:15:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835593002/20001
5 years, 11 months ago (2015-01-05 03:48:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/1410)
5 years, 11 months ago (2015-01-05 04:05:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835593002/40001
5 years, 11 months ago (2015-01-05 04:16:28 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/03119ba4f815bc2c2774a9349ca8278ab1695072
5 years, 11 months ago (2015-01-05 04:24:48 UTC) #13
reed2
5 years, 11 months ago (2015-01-05 04:51:16 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/811863006/ by reed@chromium.org.

The reason for reverting is: did I break the build?.

Powered by Google App Engine
This is Rietveld 408576698