Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 835583003: Reduce overhead of SkFontHost_FreeType::onFilterRec. (Closed)

Created:
5 years, 11 months ago by bungeman-skia
Modified:
5 years, 11 months ago
Reviewers:
jvanverth1, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reduce overhead of SkFontHost_FreeType::onFilterRec. The current code is using AutoFTAccess just to access the FT_Library. However, it does not need to resolve the FT_Face, just the FT_Library. This unecessary overhead and is removed by this change. The longer term solution is for SkFontMgr to initialize FreeType. Committed: https://skia.googlesource.com/skia/+/d4742fa550bafce5225cd267437eadef177c5945

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +9 lines, -5 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
bungeman-skia
There's a longer term plan, but we can make things faster in the meantime.
5 years, 11 months ago (2015-01-21 16:37:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835583003/1
5 years, 11 months ago (2015-01-21 17:44:09 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-21 17:44:10 UTC) #5
jvanverth1
lgtm
5 years, 11 months ago (2015-01-21 19:17:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d4742fa550bafce5225cd267437eadef177c5945
5 years, 11 months ago (2015-01-21 19:19:26 UTC) #7
reed1
5 years, 11 months ago (2015-01-21 19:29:34 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/835583003/diff/1/src/ports/SkFontHost_FreeTyp...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/835583003/diff/1/src/ports/SkFontHost_FreeTyp...
src/ports/SkFontHost_FreeType.cpp:704: if (!gFTLibrary->isLCDSupported() &&
isLCD(*rec)) {
maybe move the isLCD() check outside of the mutex-grab?

Powered by Google App Engine
This is Rietveld 408576698