When building with component=shared_library on linux, add -rdynamic

When building with component=shared_library on linux, add -rdynamic

This allows for WTF's BACKTRACE() macro to symbolize stacktraces.

BUG=none
R=glider@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237048

[Alexander Potapenko, 2013-11-22 13:41:45]

LGTM

On Fri, Nov 22, 2013 at 5:39 PM,  <jochen@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> When building with component=shared_library on linux, add -rdynamic
>
> This allows for WTF's BACKTRACE() macro to symbolize stacktraces.
>
> BUG=none
> R=glider@chromium.org
>
> Please review this at https://codereview.chromium.org/83553002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+5, -7 lines):
>   M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
05f0f241061a33f7cb067f38c7b832456ab1d941..5635dfa20a33be587aa5823b1086f9a0fc1cb88b
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -3488,19 +3488,17 @@
>                }],
>              ],
>            }],
> +          ['component=="shared_library"', {
> +            # See crbug.com/112389. Also required for BACKTRACE() to work.
> +            # TODO(glider): replace with --dynamic-list or something
> +            'ldflags': ['-rdynamic'],
> +          }],
>            ['linux_use_heapchecker==1', {
>              'variables': {'linux_use_tcmalloc%': 1},
>              'defines': [
>                  'USE_HEAPCHECKER',
>                  'MEMORY_TOOL_REPLACES_ALLOCATOR',
>              ],
> -            'conditions': [
> -              ['component=="shared_library"', {
> -                # See crbug.com/112389
> -                # TODO(glider): replace with --dynamic-list or something
> -                'ldflags': ['-rdynamic'],
> -              }],
> -            ],
>            }],
>            ['linux_use_tcmalloc==0 and android_use_tcmalloc==0', {
>              'defines': ['NO_TCMALLOC'],
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-11-22 13:42:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/83553002/1

[commit-bot: I haz the power, 2013-11-22 17:38:33]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-22 17:43:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/83553002/1

[commit-bot: I haz the power, 2013-11-22 20:37:53]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-22 22:10:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/83553002/1

[commit-bot: I haz the power, 2013-11-23 01:18:30]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-23 19:44:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/83553002/1

[commit-bot: I haz the power, 2013-11-23 22:43:26]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[jochen (gone - plz use gerrit), 2013-11-25 09:18:07]

Committed patchset #1 manually as r237048 (presubmit successful).