Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 835523006: Explicitly suppress scrolling for wheel events that will trigger zooming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add DCHECK Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 4f0e5699b778ac917094a0545d864eec1a4f5307..ecbbd7edabc2e604a15ad34d81c6bf37064c5149 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -323,6 +323,15 @@ class MockWindowObserver : public aura::WindowObserver {
MOCK_METHOD2(OnDelegatedFrameDamage, void(aura::Window*, const gfx::Rect&));
};
+const WebInputEvent* GetInputEventFromMessage(const IPC::Message& message) {
+ PickleIterator iter(message);
+ const char* data;
+ int data_length;
+ if (!iter.ReadData(&data, &data_length))
+ return NULL;
+ return reinterpret_cast<const WebInputEvent*>(data);
+}
+
} // namespace
class RenderWidgetHostViewAuraTest : public testing::Test {
@@ -403,6 +412,15 @@ class RenderWidgetHostViewAuraTest : public testing::Test {
RendererFrameManager::GetInstance()->OnMemoryPressure(level);
}
+ void SendInputEventACK(WebInputEvent::Type type,
+ InputEventAckState ack_result) {
+ InputHostMsg_HandleInputEvent_ACK_Params ack;
+ ack.type = type;
+ ack.state = ack_result;
+ InputHostMsg_HandleInputEvent_ACK response(0, ack);
+ widget_host_->OnMessageReceived(response);
+ }
+
protected:
// If true, then calls RWH::Shutdown() instead of deleting RWH.
bool widget_host_uses_shutdown_to_destroy_;
@@ -595,15 +613,6 @@ class RenderWidgetHostViewAuraOverscrollTest
velocityX, velocityY, sourceDevice));
}
- void SendInputEventACK(WebInputEvent::Type type,
- InputEventAckState ack_result) {
- InputHostMsg_HandleInputEvent_ACK_Params ack;
- ack.type = type;
- ack.state = ack_result;
- InputHostMsg_HandleInputEvent_ACK response(0, ack);
- widget_host_->OnMessageReceived(response);
- }
-
bool ScrollStateIsContentScrolling() const {
return scroll_state() == OverscrollController::STATE_CONTENT_SCROLLING;
}
@@ -3079,4 +3088,57 @@ TEST_F(RenderWidgetHostViewAuraTest, KeyEvent) {
}
}
+TEST_F(RenderWidgetHostViewAuraTest, SetCanScrollForWebMouseWheelEvent) {
+ view_->InitAsChild(NULL);
+ view_->Show();
+
+ sink_->ClearMessages();
+
+ // Simulates the mouse wheel event with ctrl modifier applied.
+ ui::MouseWheelEvent event(gfx::Vector2d(1, 1),
+ gfx::Point(), gfx::Point(),
+ ui::EF_CONTROL_DOWN, 0);
+ view_->OnMouseEvent(&event);
+
+ const WebInputEvent* input_event =
+ GetInputEventFromMessage(*sink_->GetMessageAt(0));
+ const WebMouseWheelEvent* wheel_event =
+ static_cast<const WebMouseWheelEvent*>(input_event);
+ // Check if the canScroll set to false when ctrl-scroll is generated from
+ // mouse wheel event.
+ EXPECT_FALSE(wheel_event->canScroll);
+ sink_->ClearMessages();
+
+ // Ack'ing the outstanding event should flush the pending event queue.
+ SendInputEventACK(blink::WebInputEvent::MouseWheel,
+ INPUT_EVENT_ACK_STATE_CONSUMED);
+
+ // Simulates the mouse wheel event with no modifier applied.
+ event = ui::MouseWheelEvent(gfx::Vector2d(1, 1), gfx::Point(), gfx::Point(),
+ ui::EF_NONE, 0);
+
+ view_->OnMouseEvent(&event);
+
+ input_event = GetInputEventFromMessage(*sink_->GetMessageAt(0));
+ wheel_event = static_cast<const WebMouseWheelEvent*>(input_event);
+ // Check if the canScroll set to true when no modifier is applied to the
+ // mouse wheel event.
+ EXPECT_TRUE(wheel_event->canScroll);
+ sink_->ClearMessages();
+
+ SendInputEventACK(blink::WebInputEvent::MouseWheel,
+ INPUT_EVENT_ACK_STATE_CONSUMED);
+
+ // Simulates the scroll event with ctrl modifier applied.
+ ui::ScrollEvent scroll(ui::ET_SCROLL, gfx::Point(2, 2), ui::EventTimeForNow(),
+ ui::EF_CONTROL_DOWN, 0, 5, 0, 5, 2);
+ view_->OnScrollEvent(&scroll);
+
+ input_event = GetInputEventFromMessage(*sink_->GetMessageAt(0));
+ wheel_event = static_cast<const WebMouseWheelEvent*>(input_event);
+ // Check if the canScroll set to true when ctrl-touchpad-scroll is generated
+ // from scroll event.
+ EXPECT_TRUE(wheel_event->canScroll);
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698