components/password_manager/content/renderer/credential_manager_client.cc - Issue 835523004: Credential Manager API: Enable forward declaration for CredentialType enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.cc

Issue 835523004: Credential Manager API: Enable forward declaration for CredentialType enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/common/credential_manager_types.cc ('k') | components/password_manager/content/renderer/credential_manager_client_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.cc

diff --git a/components/password_manager/content/renderer/credential_manager_client.cc b/components/password_manager/content/renderer/credential_manager_client.cc

index e6941583c999ac3428664b53f6ac5063c5f128d5..def7aa61bb64eef659e970460c3f6234b3e337b9 100644

--- a/components/password_manager/content/renderer/credential_manager_client.cc

+++ b/components/password_manager/content/renderer/credential_manager_client.cc

@@ -82,15 +82,15 @@ void CredentialManagerClient::OnSendCredential(int request_id,

DCHECK(callbacks);

scoped_ptr<blink::WebCredential> credential = nullptr;

switch (info.type) {

- case CREDENTIAL_TYPE_FEDERATED:

+ case CredentialType::CREDENTIAL_TYPE_FEDERATED:

credential.reset(new blink::WebFederatedCredential(

info.id, info.name, info.avatar, info.federation));

break;

- case CREDENTIAL_TYPE_LOCAL:

+ case CredentialType::CREDENTIAL_TYPE_LOCAL:

credential.reset(new blink::WebLocalCredential(info.id, info.name,

info.avatar, info.password));

break;

- case CREDENTIAL_TYPE_EMPTY:

+ case CredentialType::CREDENTIAL_TYPE_EMPTY:

// Intentionally empty; we'll send nullptr to the onSuccess call below.

break;

}