cros: Use first unlock user's pref for locking screen.

cros: Use first unlock user's pref for locking screen.

Use first unlock user (which is the primary user at the
moment) pref for locking screen;

BUG=322662
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236931

[Daniel Erat, 2013-11-22 23:14:47]

https://codereview.chromium.org/83543004/diff/1/chrome/browser/ui/ash/session...
File chrome/browser/ui/ash/session_state_delegate_chromeos.cc (right):

https://codereview.chromium.org/83543004/diff/1/chrome/browser/ui/ash/session...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:47: DCHECK_EQ(1u,
unlock_users.size());
is this _EQ correct, or should it be DCHECK_LE(unlock_users.size(), 1u)?

https://codereview.chromium.org/83543004/diff/1/chrome/browser/ui/ash/session...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:59: DCHECK_EQ(1u,
unlock_users.size());
same question here

[Mr4D (OOO till 08-26), 2013-11-22 23:30:50]

not much to add since derat asked my questions already. It is possible that
there could be more then one users be able to unlock.

https://codereview.chromium.org/83543004/diff/1/chrome/browser/ui/ash/session...
File chrome/browser/ui/ash/session_state_delegate_chromeos.cc (right):

https://codereview.chromium.org/83543004/diff/1/chrome/browser/ui/ash/session...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:46:
chromeos::UserManager::Get()->GetUnlockUsers();
As long as there is at least one user, he should be able to lock the screen.

[Daniel Erat, 2013-11-22 23:39:40]

https://codereview.chromium.org/83543004/diff/1/chrome/browser/ui/ash/session...
File chrome/browser/ui/ash/session_state_delegate_chromeos.cc (right):

https://codereview.chromium.org/83543004/diff/1/chrome/browser/ui/ash/session...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:46:
chromeos::UserManager::Get()->GetUnlockUsers();
On 2013/11/22 23:30:51, Mr4D wrote:
> As long as there is at least one user, he should be able to lock the screen.

my question was actually about whether it's possible to have zero users that can
unlock the screen. is this method e.g. ever called from the login screen?

[xiyuan, 2013-11-22 23:46:13]

Also reverted the screen_locker.cc changes so that we always switch to the
unlocking user's desktop per MinLi.

https://codereview.chromium.org/83543004/diff/1/chrome/browser/ui/ash/session...
File chrome/browser/ui/ash/session_state_delegate_chromeos.cc (right):

https://codereview.chromium.org/83543004/diff/1/chrome/browser/ui/ash/session...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:47: DCHECK_EQ(1u,
unlock_users.size());
On 2013/11/22 23:14:47, Daniel Erat wrote:
> is this _EQ correct, or should it be DCHECK_LE(unlock_users.size(), 1u)?

Good catch. I did not realize this could be called before user login. So 0 is
also a valid size here.

Changed to DCHECK_LE(unlock_users.size(), 1u) and updated GetUnlockUsers to not
CHECK.

https://codereview.chromium.org/83543004/diff/1/chrome/browser/ui/ash/session...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:59: DCHECK_EQ(1u,
unlock_users.size());
On 2013/11/22 23:14:47, Daniel Erat wrote:
> same question here

Done.

[Daniel Erat, 2013-11-23 00:08:23]

lgtm

[Mr4D (OOO till 08-26), 2013-11-23 00:52:26]

lgtm

(later on we should possibly change the selection of unlockable users, but for
now this is correct)

https://codereview.chromium.org/83543004/diff/180001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/user_manager_impl.cc (right):

https://codereview.chromium.org/83543004/diff/180001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/user_manager_impl.cc:306:
unlock_users.push_back(primary_user_);
Just checking: So only one user can unlock the session? Somehow I always thought
that - if no enterprise settings were given - every user could do that?

[xiyuan, 2013-11-23 01:17:11]

On 2013/11/23 00:52:26, Mr4D wrote:
> lgtm
> 
> (later on we should possibly change the selection of unlockable users, but for
> now this is correct)
> 
>
https://codereview.chromium.org/83543004/diff/180001/chrome/browser/chromeos/...
> File chrome/browser/chromeos/login/user_manager_impl.cc (right):
> 
>
https://codereview.chromium.org/83543004/diff/180001/chrome/browser/chromeos/...
> chrome/browser/chromeos/login/user_manager_impl.cc:306:
> unlock_users.push_back(primary_user_);
> Just checking: So only one user can unlock the session? Somehow I always
thought
> that - if no enterprise settings were given - every user could do that?

Yep, we will need to revisit this. The current code is added for M31 per
http://crbug.com/292991 that only allow primary user to unlock.

[commit-bot: I haz the power, 2013-11-23 01:19:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/83543004/180001

[commit-bot: I haz the power, 2013-11-23 02:48:44]

Change committed as 236931