WATCH aura, x11 and message-loop.

WATCH aura, x11 and message-loop.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106354

[sadrul, 2011-10-19 19:07:02]

I am not sure who is the proper person for reviewing WATCHLISTS

[Ben Goodger (Google), 2011-10-19 19:07:39]

LGTM

On Wed, Oct 19, 2011 at 12:07 PM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> I am not sure who is the proper person for reviewing WATCHLISTS
>
> Description:
> WATCH aura, x11 and message-loop.
>
> BUG=none
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/8354010/<http://codereview.chromium.org/8354...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M WATCHLISTS
>
>
> Index: WATCHLISTS
> diff --git a/WATCHLISTS b/WATCHLISTS
> index 03adaf7e08de328207df8e128ab651**4e8eadec6d..**
> 27cccfefc04b8f0e37c374b62d3b16**2cb5363d4e 100644
> --- a/WATCHLISTS
> +++ b/WATCHLISTS
> @@ -293,6 +293,9 @@
>       'filepath': 'chrome/browser/autocomplete/.***'\
>                   '|chrome/browser/ui/.*/**omnibox/.*'
>     },
> +    'message_loop': {
> +      'filepath': 'base/message_*'
> +    },
>   },
>
>   'WATCHLISTS': {
> @@ -385,7 +388,7 @@
>     'accelerator_table_linux': ['mazda@chromium.org',
>                                 'derat+watch@chromium.org'],
>     'downloads_ui': ['asanka@chromium.org', 'rdsmith@chromium.org'],
> -    'x11': ['derat+watch@chromium.org'],
> +    'x11': ['derat+watch@chromium.org', 'sadrul@chromium.org'],
>     'accessibility': ['dmazzoni+watch@chromium.org'**,
>                       'dtseng+watch@chromium.org',
>                       'ctguil+watch@chromium.org',
> @@ -395,11 +398,12 @@
>                       'hashimoto+watch@chromium.org'**,
>                       'yoshiki+watch@chromium.org',
>                       'yuzo+watch@chromium.org'],
> -    'aura': ['ben+watch@chromium.org'],
> +    'aura': ['ben+watch@chromium.org', 'sadrul@chromium.org'],
>     'views_core': ['ben+watch@chromium.org'],
>     'tools_emacs': ['fischman+watch@chromium.org'**],
>     'browser_compositor': ['backer@chromium.org'],
>     'textinput': ['suzhe@chromium.org'],
>     'omnibox': ['suzhe@chromium.org'],
> +    'message_loop': ['sadrul@chromium.org'],
>   },
>  }
>
>
>

[Nirnimesh, 2011-10-19 19:12:30]

http://codereview.chromium.org/8354010/diff/1/WATCHLISTS
File WATCHLISTS (right):

http://codereview.chromium.org/8354010/diff/1/WATCHLISTS#newcode297
WATCHLISTS:297: 'filepath': 'base/message_*'
this isn't a valid regex. Use .*, not *

[sadrul, 2011-10-19 19:14:03]

http://codereview.chromium.org/8354010/diff/1/WATCHLISTS
File WATCHLISTS (right):

http://codereview.chromium.org/8354010/diff/1/WATCHLISTS#newcode297
WATCHLISTS:297: 'filepath': 'base/message_*'
On 2011/10/19 19:12:31, Nirnimesh wrote:
> this isn't a valid regex. Use .*, not *

Doh! Thanks for catching this. Fixed.

[Nirnimesh, 2011-10-19 19:27:15]

lgtm