Issue 8353039: Temporarily disable CheckRietveldTryJobExecution() while the Rietveld API is being upgraded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8353039: Temporarily disable CheckRietveldTryJobExecution() while the Rietveld API is being upgraded (Closed)

Created:
9 years, 1 month ago by M-A Ruel

Modified:
4 years, 8 months ago

Reviewers:
nsylvain

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Temporarily disable CheckRietveldTryJobExecution() while the Rietveld API is being upgraded BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107590

Patch Set 1 #

Patch Set 2 : typo #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -86 lines)			Patch
	M	presubmit_canned_checks.py	View	1	1 chunk	+2 lines, -44 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		1 chunk	+0 lines, -42 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nsylvain

I'm ok with this change as long as we plan to revert tomorrow. lgtm

9 years, 1 month ago (2011-10-27 17:06:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8353039/2001

9 years, 1 month ago (2011-10-27 17:07:29 UTC) #2

tandrii(chromium)

4 years, 8 months ago (2016-04-26 17:05:48 UTC) #4

Message was sent while issue was closed.

On 2011/10/27 17:13:32, commit-bot: I haz the power wrote:
> Change committed as 107590

hm, i think this has never been reverted :D But that's good, more dead code to
kill.

Expand Messages | Collapse Messages