Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 835273006: Remove isRenderingReady. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan, abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove isRenderingReady. All this method did was check if imports were loaded, and sky's parser will wait on imports anyway, so there's no reason to block rendering on imports as they'll likely be at the top of the document and stop the rest of the page from being appended or rendered. Sky apps will probably also want more control over rendering and not want the old school web style of incremental rendering. R=abarth@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/db6850fada0dc3ce132b62cf80e699d764ce1420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M sky/engine/core/dom/Document.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-13 04:46:00 UTC) #2
esprehn
5 years, 11 months ago (2015-01-13 06:11:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db6850fada0dc3ce132b62cf80e699d764ce1420 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698