Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 835253002: Update mojo sdk to rev e3719475d5971283d1d2250533d53066b2ff9797 (Closed)

Created:
5 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, dtapuska
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev e3719475d5971283d1d2250533d53066b2ff9797 Includes diff from comment #6 at https://codereview.chromium.org/803173009 BUG=None TBR=darin@chromium.org TBR=jamesr@chromium.org Committed: https://crrev.com/84b8c80778fa2c728470c557c379ef34a1b525b0 Cr-Commit-Position: refs/heads/master@{#310049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -77 lines) Patch
M content/browser/webui/web_ui_data_source_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/content_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lazy_interface_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/handle.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/test_structs.mojom View 1 chunk +1 line, -4 lines 0 comments Download
A mojo/public/js/bindings.js View 1 chunk +100 lines, -0 lines 0 comments Download
M mojo/public/js/connection.js View 3 chunks +22 lines, -39 lines 0 comments Download
M mojo/public/js/constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/js/constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/js/struct_unittests.js View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/sky/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 2 chunks +8 lines, -10 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.sky.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 chunk +15 lines, -0 lines 0 comments Download
M mojo/services/public/js/service_provider.js View 4 chunks +14 lines, -9 lines 0 comments Download
M mojo/services/public/js/shell.js View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ken Rockot(use gerrit already)
5 years, 11 months ago (2015-01-06 04:16:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835253002/1
5 years, 11 months ago (2015-01-06 04:17:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 04:28:20 UTC) #4
jamesr
lgtm
5 years, 11 months ago (2015-01-06 04:28:48 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 04:29:14 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/84b8c80778fa2c728470c557c379ef34a1b525b0
Cr-Commit-Position: refs/heads/master@{#310049}

Powered by Google App Engine
This is Rietveld 408576698