Re-enable pdfium_unittests.

Re-enable pdfium_unittests.

In order for the standalone pdfium build to succeed,
DEPS is updated to pull in gtest, and a stub gtest.gyp
file is provided (which is unused under a chromium
checkout).

R=brucedawson@chromium.org, thakis@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/a48ead9b7e3dc01f1bde83f69062eebd960edfdc

[Tom Sepez, 2015-01-05 22:52:22]

tsepez@chromium.org changed reviewers:
+ brucedawson@chromium.org, thakis@chromium.org

[Tom Sepez, 2015-01-05 22:53:13]

Nico, please review.
Bruce, could you pull this patch, and double-check.

[Nico, 2015-01-05 22:58:01]

lgtm as far as I can tell.

https://codereview.chromium.org/835233002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/835233002/diff/1/DEPS#newcode2
DEPS:2: # standalone case, not when building as part of chromium.
This is not 100% true – if this file had an include_rules section, it would
still get used in Chromium I believe.

https://codereview.chromium.org/835233002/diff/1/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/835233002/diff/1/pdfium.gyp#newcode814
pdfium.gyp:814: '<(DEPTH)'
Do you need this?

[brucedawson, 2015-01-05 23:06:18]

I applied the patch and verified that I can build everything (Release and Debug,
no targets specified).

But, I didn't see a unit-tests binary created. Just the usual mksnapshot.exe and
pdfium_test.exe.

So, lgtm, as long as that is expected behavior.

[Tom Sepez, 2015-01-05 23:08:09]

https://codereview.chromium.org/835233002/diff/1/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/835233002/diff/1/pdfium.gyp#newcode814
pdfium.gyp:814: '<(DEPTH)'
On 2015/01/05 22:58:01, Nico wrote:
> Do you need this?

Yes, get fx_basic_bstring_unittest.cpp:5:47: fatal error:
testing/gtest/include/gtest/gtest.h: No such file or directory otherwise.

[brucedawson, 2015-01-05 23:08:25]

testing/gtest directory now shows up in "Untracked files" when I go "git
status". I assume that is from this change. Is a .gitignore entry needed?

[Tom Sepez, 2015-01-05 23:09:26]

Bruce, what about making an explicit pdfium_unittests(.exe if required) target?

[brucedawson, 2015-01-05 23:11:33]

Ah -- that works. Specifying pdfium_unittests.exe works like a charm.

I expected no-target to mean all-targets, but my expectations are not to be
trusted.

[Tom Sepez, 2015-01-05 23:12:31]

On 2015/01/05 23:08:25, brucedawson wrote:
> testing/gtest directory now shows up in "Untracked files" when I go "git
> status". I assume that is from this change. Is a .gitignore entry needed?
Yup.

[Tom Sepez, 2015-01-05 23:28:32]

Nico, you OK with the new .gitignore file?

[Nico, 2015-01-05 23:29:05]

still lgtm

[Tom Sepez, 2015-01-05 23:30:30]

Committed patchset #3 (id:40001) manually as
a48ead9b7e3dc01f1bde83f69062eebd960edfdc (presubmit successful).