Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 835223006: Revert of linux/gyp: Find missing symbols at build time, not runtime. (Closed)

Created:
5 years, 11 months ago by Timothy Loh
Modified:
5 years, 11 months ago
CC:
chromium-reviews, sadrul, tdresser+watch_chromium.org, tfarina, jam, dcheng, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, jdduke+watch_chromium.org, Alexander Potapenko, earthdok
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of linux/gyp: Find missing symbols at build time, not runtime. (patchset #10 id:180001 of https://codereview.chromium.org/854753002/) Reason for revert: Breaks compile on chromium.webkit/Linux Tests (dbg) and probably also chromium.lkgr/ASAN Debug http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29?numbuilds=50 http://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Debug Original issue's description: > linux/gyp: Find missing symbols at build time, not runtime. > > Limited to very few cases for now (non-chromeos, non-android, > non-official, component builds only). > > BUG=371125 > TBR=piman,dalecurtis > > Committed: https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e > Cr-Commit-Position: refs/heads/master@{#312020} > > Committed: https://crrev.com/fdaea4c9e63c845db9c009d236205e7ed4fcb663 > Cr-Commit-Position: refs/heads/master@{#312032} TBR=jamesr@chromium.org,piman@chromium.org,dalecurtis@chromium.org,machenbach@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=371125 Committed: https://crrev.com/6019325be9a7a4195368d8d4362047e1a4381541 Cr-Commit-Position: refs/heads/master@{#312068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M ash/ash.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/gpu_config.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M media/media_cdm.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mesa/mesa.gyp View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/display/display.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/events.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/platform/x11/x11_events_platform.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/views.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/wm/wm.gyp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Timothy Loh
Created Revert of linux/gyp: Find missing symbols at build time, not runtime.
5 years, 11 months ago (2015-01-19 05:19:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835223006/1
5 years, 11 months ago (2015-01-19 05:19:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-19 05:20:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6019325be9a7a4195368d8d4362047e1a4381541 Cr-Commit-Position: refs/heads/master@{#312068}
5 years, 11 months ago (2015-01-19 05:21:25 UTC) #4
inferno
On 2015/01/19 05:20:29, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) thakis@ ...
5 years, 11 months ago (2015-01-19 05:21:27 UTC) #5
inferno
On 2015/01/19 05:21:27, inferno wrote: > On 2015/01/19 05:20:29, I haz the power (commit-bot) wrote: ...
5 years, 11 months ago (2015-01-19 05:22:00 UTC) #6
Timothy Loh
On 2015/01/19 05:22:00, inferno wrote: > On 2015/01/19 05:21:27, inferno wrote: > > On 2015/01/19 ...
5 years, 11 months ago (2015-01-19 05:29:37 UTC) #7
Nico
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/860623002/ by thakis@chromium.org. ...
5 years, 11 months ago (2015-01-19 05:41:20 UTC) #8
Timothy Loh
5 years, 11 months ago (2015-01-19 05:55:06 UTC) #9
Message was sent while issue was closed.
On 2015/01/19 05:41:20, Nico wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/860623002/ by mailto:thakis@chromium.org.
> 
> The reason for reverting is: not on cq => doesn't qualify for reverts. will
fix
> live..

Linux Tests (dbg) is a Blink tree closer :\

Powered by Google App Engine
This is Rietveld 408576698