Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 835183002: Further instrumentations to find jank in Windows message processing. (Closed)

Created:
5 years, 11 months ago by vadimt
Modified:
5 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Further instrumentations to find jank in Windows message processing. Based on the latest revelations: 440919 WindowImpl::WndProc2 = 90 jph. Since the internals of OnWndProc are instrumented, this strangely indicates that it's GetWindowUserData who is responsible for this jank. Instrumenting it. 440919 <<MessagePumpForUI::ProcessNextWindowsMessage>> = 46 jph and 440919 MessagePumpForUI::ProcessMessageHelper = 39 jph This means that with instrumenting MessagePumpForUI::ProcessMessageHelper, we've divided MessagePumpForUI::ProcessNextWindowsMessage into 2 roughly equal parts: everything that happens inside MessagePumpForUI::ProcessMessageHelper, and everything outside (GetQueueStatus and PeekMessage). Adding in instrumentation to separate GetQueueStatus from PeekMessage. Also instrumenting internals of MessagePumpForUI::ProcessMessageHelper. BUG=440919 Committed: https://crrev.com/4949a513d841da01d66a32f54a98fec518c3fde3 Cr-Commit-Position: refs/heads/master@{#310156}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M base/message_loop/message_pump_win.cc View 5 chunks +24 lines, -4 lines 0 comments Download
M ui/gfx/win/hwnd_util.cc View 2 chunks +5 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
vadimt
cpu@, please review
5 years, 11 months ago (2015-01-05 21:54:29 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/835183002/diff/1/ui/gfx/win/hwnd_util.cc File ui/gfx/win/hwnd_util.cc (right): https://codereview.chromium.org/835183002/diff/1/ui/gfx/win/hwnd_util.cc#newcode124 ui/gfx/win/hwnd_util.cc:124: return NULL; It would be very surprising if ...
5 years, 11 months ago (2015-01-06 20:46:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835183002/1
5 years, 11 months ago (2015-01-06 20:48:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 22:08:09 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4949a513d841da01d66a32f54a98fec518c3fde3 Cr-Commit-Position: refs/heads/master@{#310156}
5 years, 11 months ago (2015-01-06 22:09:01 UTC) #7
falken
5 years, 11 months ago (2015-01-07 02:50:35 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/830423008/ by falken@chromium.org.

The reason for reverting is: Speculative revert for Windows failures on Blink
waterfall. They also appear on the trybots so will try a tryjob first..

Powered by Google App Engine
This is Rietveld 408576698