Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 835113002: Remove draw window size state from SkDebugCanvas (Closed)

Created:
5 years, 11 months ago by Kimmo Kinnunen
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@debugger-small-things-04-index-zero-draw
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove draw window size state from SkDebugCanvas The SkDebugCanvas can be (or is currently) being used to draw to multiple different canvases. If this use-case is intended, then storing draw -related state in the canvas causes bugs. Remove draw window size state form SkDebugCanvas. Instead, use the canvas base layer size as the window size to clip to. This is consistent with the current use in debugger. This is part of work trying to remove bugs in debugger that result from replaying one SkDrawCanvas to two different canvases. Currently the SkDrawCanvas stores state that can only be valid if it is used for one canvas. Committed: https://skia.googlesource.com/skia/+/26e5400de4db969d32356a0b703261c1c98735f6

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M debugger/QT/SkGLWidget.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M debugger/QT/SkRasterWidget.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M debugger/SkDebugger.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kimmo Kinnunen
5 years, 11 months ago (2015-01-05 12:47:57 UTC) #2
robertphillips
lgtm
5 years, 11 months ago (2015-01-05 20:48:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835113002/20001
5 years, 11 months ago (2015-01-05 20:49:30 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 20:58:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/26e5400de4db969d32356a0b703261c1c98735f6

Powered by Google App Engine
This is Rietveld 408576698