Issue 8351086: Merge 107841 - Fix a crash in FullscreenExitBubbleController when the user clicks the "Exit full ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8351086: Merge 107841 - Fix a crash in FullscreenExitBubbleController when the user clicks the "Exit full ... (Closed)

Created:
9 years, 1 month ago by jeremya

Modified:
9 years, 1 month ago

Reviewers:
jeremya

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/branches/912/src/

Visibility:
Public.

Description

Merge 107841 - Fix a crash in FullscreenExitBubbleController when the user clicks the "Exit full screen" button. The crash was due to the fact that Browser::OnDenyFullscreenPermission causes BrowserWindow::ExitFullscreen to be called, which causes the FullscreenExitBubbleController to be destroyed. [FullscreenExitBubbleController deny:] was sending a -hideSoon message to its zombie self following the call to Browser::OnDenyFullscreenPermission. BUG=101835 TEST=The browser doesn't crash when you click "Exit full screen" on a fullscreened page. Review URL: http://codereview.chromium.org/8399017 TBR=jeremya@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108353

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -6 lines)			Patch
M	chrome/browser/ui/browser.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm	View	3 chunks	+60 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages