Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 83483012: [webcrypto] Add RSA private key PKCS#8 import for NSS. (Closed)

Created:
7 years, 1 month ago by padolph
Modified:
7 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[webcrypto] Add RSA private key PKCS#8 import for NSS. Depends on Issue 62633004. BUG=245025 TEST=content_unittests --gtest_filter="WebCryptoImpl*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237523

Patch Set 1 #

Total comments: 12

Patch Set 2 : fixes for rsleevi and eroman #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -40 lines) Patch
M content/renderer/webcrypto/webcrypto_impl_nss.cc View 1 5 chunks +94 lines, -39 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_unittest.cc View 1 chunk +81 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
padolph
7 years, 1 month ago (2013-11-23 02:31:34 UTC) #1
Ryan Sleevi
NSS functions LGTM, but please wait for eroman on the Web Crypto side https://codereview.chromium.org/83483012/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc File ...
7 years ago (2013-11-25 06:59:43 UTC) #2
padolph
https://codereview.chromium.org/83483012/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc File content/renderer/webcrypto/webcrypto_impl_nss.cc (right): https://codereview.chromium.org/83483012/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc#newcode342 content/renderer/webcrypto/webcrypto_impl_nss.cc:342: // according to RFC 4055 this can be used ...
7 years ago (2013-11-25 23:02:58 UTC) #3
eroman
This LGTM, however please upload the patchset which addresses Ryan's comments. Thanks! https://codereview.chromium.org/83483012/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc File content/renderer/webcrypto/webcrypto_impl_nss.cc ...
7 years ago (2013-11-26 03:40:28 UTC) #4
padolph
https://codereview.chromium.org/83483012/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc File content/renderer/webcrypto/webcrypto_impl_nss.cc (right): https://codereview.chromium.org/83483012/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc#newcode455 content/renderer/webcrypto/webcrypto_impl_nss.cc:455: // TODO(padolph): Verify correct values of isPerm, isPrivate, and ...
7 years ago (2013-11-27 03:35:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/padolph@netflix.com/83483012/100001
7 years ago (2013-11-27 03:51:19 UTC) #6
commit-bot: I haz the power
7 years ago (2013-11-27 05:43:10 UTC) #7
Message was sent while issue was closed.
Change committed as 237523

Powered by Google App Engine
This is Rietveld 408576698