Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 83483007: Expose synthetic delays through the GPU benchmarking extension (Closed)

Created:
7 years, 1 month ago by Sami
Modified:
6 years, 11 months ago
Reviewers:
nduca, brianderson
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, dsinclair+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Expose synthetic delays through the GPU benchmarking extension This patch makes it possible to use the GPU benchmarking extension to configure synthetic delays. We add a new function with the following signature: chrome.gpuBenchmarking.configureSyntheticDelay( name, target_duration, mode, callback) where |name| is the delay point name, |target_duration| is the desired delay point execution time, |mode| is one of "static", "oneshot" or "alternating". |callback| is invoked once all processes of the browser have acknowledged the new delay setting. BUG=307841

Patch Set 1 #

Total comments: 1

Patch Set 2 : Checkpoint: configure all delays atomically #

Patch Set 3 : Spun off TracingController part to https://codereview.chromium.org/98953002/ #

Patch Set 4 : Forward delays in RenderWidgetHostImpl properly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 5 chunks +26 lines, -0 lines 0 comments Download
A content/common/synthetic_delay_configuration.h View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A content/common/synthetic_delay_configuration.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 5 chunks +13 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 2 6 chunks +111 lines, -0 lines 0 comments Download
M content/renderer/render_widget.h View 1 5 chunks +12 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sami
Here's the IPC for synthetic delay configuration. This is the part I'm least happy about ...
7 years, 1 month ago (2013-11-22 18:49:26 UTC) #1
nduca
how about splitting up the part where we trigger it from the gpu bench extension ...
7 years ago (2013-11-24 19:41:53 UTC) #2
nduca
https://codereview.chromium.org/83483007/diff/1/content/browser/tracing/tracing_controller_impl.cc File content/browser/tracing/tracing_controller_impl.cc (right): https://codereview.chromium.org/83483007/diff/1/content/browser/tracing/tracing_controller_impl.cc#newcode360 content/browser/tracing/tracing_controller_impl.cc:360: void TracingControllerImpl::ConfigureSyntheticDelay( i think you need to configure them ...
7 years ago (2013-11-24 19:42:00 UTC) #3
Sami
7 years ago (2013-12-02 12:26:03 UTC) #4
On 2013/11/24 19:42:00, nduca wrote:
> i think you need to configure them all in one go, not one at a time. that'd
take
> a bit longer than I think is safe.

Good point, done.

On 2013/11/24 19:41:53, nduca wrote:
> how about splitting up the part where we trigger it from the gpu bench
extension
> from the tracing controller part? the tracing controller part lgs, i think the
> thing with the kickoff part is whether to do via rendering or maybe we could
do
> via devtools api. by splitting, we can land the stuff we know about and deal
> with just the triggering change in isolation.

Yeah, that sounds like a more productive way forward. This patch is now all
about the gpu bencmarking & render widget part and the TracingController
plumbing is at https://codereview.chromium.org/98953002/. I'll try to sketch out
what the devtools path could look like.

Powered by Google App Engine
This is Rietveld 408576698