chrome/browser/about_flags.cc - Issue 834733004: Turns off smart deploy by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 834733004: Turns off smart deploy by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: keyboard::kAutoVirtualKeyboard -> keyboard::kEnableAutoVirtualKeyboard Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index 096cdc0dfc4780576f44130e03315d07c40c1eb9..10a75ae5c71850a532770ba06110fc7ca97c1b65 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -1281,11 +1281,11 @@ const Experiment kExperiments[] = {

SINGLE_VALUE_TYPE(keyboard::switches::kEnableExperimentalInputViewFeatures)

{

- "disable-smart-virtual-keyboard",

- IDS_FLAGS_DISABLE_SMART_VIRTUAL_KEYBOARD_NAME,

- IDS_FLAGS_DISABLE_SMART_VIRTUAL_KEYBOARD_DESCRIPTION,

+ "auto-virtual-keyboard",

+ IDS_FLAGS_AUTO_VIRTUAL_KEYBOARD_NAME,

sky 2015/01/07 23:33:27 You should rename the grd fields too, eg IDS_FLAGS

rsadam 2015/01/08 15:36:33 Done.

+ IDS_FLAGS_AUTO_VIRTUAL_KEYBOARD_DESCRIPTION,

kOsCrOS,

- SINGLE_VALUE_TYPE(keyboard::switches::kDisableSmartVirtualKeyboard)

+ SINGLE_VALUE_TYPE(keyboard::switches::kAutoVirtualKeyboard)

sky 2015/01/07 23:33:27 Where does this come from? Don't you need kEnableA

rsadam 2015/01/08 15:36:33 I completely missed this when renaming. I'm surpri

#endif

{

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | ui/keyboard/keyboard_switches.h » ('j') | no next file with comments »