Turns off smart deploy by default.

Turns off smart deploy by default.

This CL will be reverted after branch.

BUG=446868
TBR=cpu
TEST=VirtualKeyboardControllerTest, VirtualKeyboardControllerAutoTest

Committed: https://crrev.com/1afa04d67e08d67b3c467f5a20182582b5abdd45
Cr-Commit-Position: refs/heads/master@{#310638}

[rsadam, 2015-01-07 16:16:25]

rsadam@chromium.org changed reviewers:
+ sky@chromium.org

[rsadam, 2015-01-07 16:16:25]

Note this CL depends on https://codereview.chromium.org/834163002/.

+sky for OWNERS ash/*, ui/keyboard/*

+TBR=cpu for .grd

[sky, 2015-01-07 17:11:31]

https://codereview.chromium.org/834733004/diff/1/ui/keyboard/keyboard_switches.h
File ui/keyboard/keyboard_switches.h (right):

https://codereview.chromium.org/834733004/diff/1/ui/keyboard/keyboard_switche...
ui/keyboard/keyboard_switches.h:41: KEYBOARD_EXPORT extern const char
kAutoVirtualKeyboard[];
Why the 'auto'? Don't you mean Enable?

[rsadam, 2015-01-07 17:26:09]

On 2015/01/07 17:11:31, sky wrote:
>
https://codereview.chromium.org/834733004/diff/1/ui/keyboard/keyboard_switches.h
> File ui/keyboard/keyboard_switches.h (right):
> 
>
https://codereview.chromium.org/834733004/diff/1/ui/keyboard/keyboard_switche...
> ui/keyboard/keyboard_switches.h:41: KEYBOARD_EXPORT extern const char
> kAutoVirtualKeyboard[];
> Why the 'auto'? Don't you mean Enable?

Auto, as in automatic deployment. Enable wouldn't be entirely accurate since the
keyboard would still be disabled in most use cases. There's also a separate flag
EnableVirtualKeyboard, which might lead to confusion.

[sky, 2015-01-07 20:41:53]

I think you then mean kEnableAutoVirtualKeyboard.

On Wed, Jan 7, 2015 at 9:26 AM,  <rsadam@chromium.org> wrote:
> On 2015/01/07 17:11:31, sky wrote:
>
>
https://codereview.chromium.org/834733004/diff/1/ui/keyboard/keyboard_switches.h
>>
>> File ui/keyboard/keyboard_switches.h (right):
>
>
>
>
https://codereview.chromium.org/834733004/diff/1/ui/keyboard/keyboard_switche...
>>
>> ui/keyboard/keyboard_switches.h:41: KEYBOARD_EXPORT extern const char
>> kAutoVirtualKeyboard[];
>> Why the 'auto'? Don't you mean Enable?
>
>
> Auto, as in automatic deployment. Enable wouldn't be entirely accurate since
> the
> keyboard would still be disabled in most use cases. There's also a separate
> flag
> EnableVirtualKeyboard, which might lead to confusion.
>
> https://codereview.chromium.org/834733004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rsadam, 2015-01-07 23:03:09]

I left the flag as auto-virtual-keyboard since there's already a histogram entry
for that. Please let me know if you'd prefer that I change that and create a new
histogram entry.

https://codereview.chromium.org/834733004/diff/1/ui/keyboard/keyboard_switches.h
File ui/keyboard/keyboard_switches.h (right):

https://codereview.chromium.org/834733004/diff/1/ui/keyboard/keyboard_switche...
ui/keyboard/keyboard_switches.h:41: KEYBOARD_EXPORT extern const char
kAutoVirtualKeyboard[];
On 2015/01/07 17:11:31, sky wrote:
> Why the 'auto'? Don't you mean Enable?

Done.

[sky, 2015-01-07 23:33:28]

https://codereview.chromium.org/834733004/diff/20001/chrome/browser/about_fla...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/834733004/diff/20001/chrome/browser/about_fla...
chrome/browser/about_flags.cc:1285: IDS_FLAGS_AUTO_VIRTUAL_KEYBOARD_NAME,
You should rename the grd fields too, eg IDS_FLAGS_ENABLE_AUTO...

https://codereview.chromium.org/834733004/diff/20001/chrome/browser/about_fla...
chrome/browser/about_flags.cc:1288:
SINGLE_VALUE_TYPE(keyboard::switches::kAutoVirtualKeyboard)
Where does this come from? Don't you need kEnableAuto...

[rsadam, 2015-01-08 15:36:33]

https://codereview.chromium.org/834733004/diff/20001/chrome/browser/about_fla...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/834733004/diff/20001/chrome/browser/about_fla...
chrome/browser/about_flags.cc:1285: IDS_FLAGS_AUTO_VIRTUAL_KEYBOARD_NAME,
On 2015/01/07 23:33:27, sky wrote:
> You should rename the grd fields too, eg IDS_FLAGS_ENABLE_AUTO...

Done.

https://codereview.chromium.org/834733004/diff/20001/chrome/browser/about_fla...
chrome/browser/about_flags.cc:1288:
SINGLE_VALUE_TYPE(keyboard::switches::kAutoVirtualKeyboard)
On 2015/01/07 23:33:27, sky wrote:
> Where does this come from? Don't you need kEnableAuto...

I completely missed this when renaming. I'm surprised it compiled without that.
In any case, fixed.

[sky, 2015-01-08 22:55:16]

LGTM

[rsadam, 2015-01-08 22:55:47]

The CQ bit was checked by rsadam@chromium.org

[commit-bot: I haz the power, 2015-01-08 22:57:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/834733004/40001

[commit-bot: I haz the power, 2015-01-09 00:32:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-09 00:33:24]

Patchset 3 (id:??) landed as
https://crrev.com/1afa04d67e08d67b3c467f5a20182582b5abdd45
Cr-Commit-Position: refs/heads/master@{#310638}