Chromium Code Reviews
DescriptionFix ChromeShell TabObservers and upstream more things
* Fixes various things that were wrong with ChromeShell and Observers,
including having its ChromeShellTabChromeWebContentsDelegateAndroid
properly call the super class methods instead of flat-out
ignoring them.
* Adds a pair of tests for the ChromeShell tab switcher to confirm
that it is brought forth and sent away properly and properly
monitoring tab title changes. The latter test catches a case
where the TabObserver was permanently being discarded after
entering and exiting the tab switcher once.
* Upstreams logic required for tab title changing.
* Upstreams more logic required for unfreezing frozen tabs,
which resulted in bringing in a truckload of other functions
like restoreIfNeeded() and the various initialize() functions.
* Upstreams random functions from ChromeTab where ChromeTab was
using Tab fields indirectly to react to events that the Tab
should have been monitoring (e.g. didStartPageLoad).
Also includes some calls to update the FullscreenManager about
events, since the FullscreenManager was previously upstreamed.
BUG=443773
TEST=AccessibilityTabSwitcherTest
Committed: https://crrev.com/c0ed134137c98c2935bf32e85f74d4e94c2b980d
Cr-Commit-Position: refs/heads/master@{#309847}
Patch Set 1 #
Total comments: 12
Patch Set 2 : cd clank #
Messages
Total messages: 9 (2 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||