Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 834723002: Fix ChromeShell TabObservers and upstream more things (Closed)

Created:
5 years, 11 months ago by gone
Modified:
5 years, 11 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, avayvod+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeShell TabObservers and upstream more things * Fixes various things that were wrong with ChromeShell and Observers, including having its ChromeShellTabChromeWebContentsDelegateAndroid properly call the super class methods instead of flat-out ignoring them. * Adds a pair of tests for the ChromeShell tab switcher to confirm that it is brought forth and sent away properly and properly monitoring tab title changes. The latter test catches a case where the TabObserver was permanently being discarded after entering and exiting the tab switcher once. * Upstreams logic required for tab title changing. * Upstreams more logic required for unfreezing frozen tabs, which resulted in bringing in a truckload of other functions like restoreIfNeeded() and the various initialize() functions. * Upstreams random functions from ChromeTab where ChromeTab was using Tab fields indirectly to react to events that the Tab should have been monitoring (e.g. didStartPageLoad). Also includes some calls to update the FullscreenManager about events, since the FullscreenManager was previously upstreamed. BUG=443773 TEST=AccessibilityTabSwitcherTest Committed: https://crrev.com/c0ed134137c98c2935bf32e85f74d4e94c2b980d Cr-Commit-Position: refs/heads/master@{#309847}

Patch Set 1 #

Total comments: 12

Patch Set 2 : cd clank #

Messages

Total messages: 9 (2 generated)
gone
5 years, 11 months ago (2014-12-31 03:09:56 UTC) #2
Ted C
https://codereview.chromium.org/834723002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://codereview.chromium.org/834723002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode1158 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1158: initializeNative(); this should go in internalInit per offline discussion ...
5 years, 11 months ago (2015-01-02 18:14:45 UTC) #3
gone
https://codereview.chromium.org/834723002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://codereview.chromium.org/834723002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode1158 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1158: initializeNative(); On 2015/01/02 18:14:45, Ted C wrote: > this ...
5 years, 11 months ago (2015-01-02 18:23:02 UTC) #4
Ted C
lgtm
5 years, 11 months ago (2015-01-02 18:38:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834723002/20001
5 years, 11 months ago (2015-01-02 18:40:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-02 19:20:40 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-02 19:21:23 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0ed134137c98c2935bf32e85f74d4e94c2b980d
Cr-Commit-Position: refs/heads/master@{#309847}

Powered by Google App Engine
This is Rietveld 408576698