Add APIs for getting bookmarks and named destinations.

fpdfsdk/src/fpdfdoc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../include/fsdk_define.h"
 #include "../include/fpdfdoc.h"
 
 static int this_module = 0;
@@ skipping 10 matching lines @@
         CPDF_Bookmark Child = tree.GetFirstChild(This);
         while (Child != NULL) {
                 // check if this item
                 CPDF_Bookmark Found = FindBookmark(tree, Child, title);
                 if (Found) return Found;
                 Child = tree.GetNextSibling(Child);
         }
         return NULL;
 }
 
+DLLEXPORT FPDF_BOOKMARK STDCALL FPDFBookmark_GetFirstChild(FPDF_DOCUMENT document, FPDF_BOOKMARK bookmark)
+{
+    if (document == NULL) return NULL;

[Tom Sepez, 2015/01/01 01:10:08]

nit: or just !document.

[Bo Xu, 2015/01/05 22:46:52]

Done.

+
+    CPDF_Document* pDoc = (CPDF_Document*)document;
+    CPDF_BookmarkTree tree(pDoc);
+    return (CPDF_Dictionary*)tree.GetFirstChild((CPDF_Dictionary*)bookmark);

[Tom Sepez, 2015/01/01 01:10:08]

The cast of the return value doen't match the declared return type above.  

[Bo Xu, 2015/01/01 06:40:38]

This is an operator in CPDF_Bookmark class. I removed it in another patch.

+}
+
+DLLEXPORT FPDF_BOOKMARK STDCALL FPDFBookmark_GetNextSibling(FPDF_DOCUMENT document, FPDF_BOOKMARK bookmark)
+{
+    if (!document || !bookmark) return NULL;
+
+    CPDF_Document* pDoc = (CPDF_Document*)document;
+    CPDF_BookmarkTree tree(pDoc);
+    return (CPDF_Dictionary*)tree.GetNextSibling((CPDF_Dictionary*)bookmark);

[Tom Sepez, 2015/01/01 01:10:08]

ditto.

[Bo Xu, 2015/01/01 06:40:38]

ditto

+}
+
+DLLEXPORT unsigned long STDCALL FPDFBookmark_GetTitle(FPDF_BOOKMARK bookmark, void* buffer, unsigned long buflen)
+{
+    if (bookmark == NULL) return 0;
+

[Tom Sepez, 2015/01/01 01:10:08]

nit: or just !bookmark

[Bo Xu, 2015/01/05 22:46:52]

Done.

+    CPDF_Bookmark Bookmark = (CPDF_Dictionary*)bookmark;

[Tom Sepez, 2015/01/01 01:10:08]

nit: maybe pBookmark to avoid starting local variable names with a capital
letter.

[Bo Xu, 2015/01/05 22:46:52]

Done.

+    CFX_WideString title = Bookmark.GetTitle();
+    CFX_ByteString bstr = title.UTF16LE_Encode(FALSE);

[Tom Sepez, 2015/01/01 01:10:08]

nit: how about encoded_title instead of bstr (following whatever convention is
in effect here (encodedTitle?)).

+    unsigned long len = bstr.GetLength();

[Tom Sepez, 2015/01/01 01:10:08]

nit: how about title_len instead of just len

+    if (buffer != NULL && buflen >= len + 2) {

[Tom Sepez, 2015/01/01 01:10:08]

nit: (buffer && buflen >= len + 2)

[Bo Xu, 2015/01/05 22:46:52]

Done.

+        FXSYS_memcpy(buffer, bstr.c_str(), len);
+        ((FX_BYTE*)buffer)[len] = ((FX_BYTE*)buffer)[len + 1] = 0;

[Tom Sepez, 2015/01/01 01:10:08]

nit: two separate statements.

[Bo Xu, 2015/01/05 22:46:52]

Done.

+    }
+    return len + 2;
+}
+
 DLLEXPORT FPDF_BOOKMARK STDCALL FPDFBookmark_Find(FPDF_DOCUMENT document, FPDF_WIDESTRING title)
 {
         if (document == NULL) return NULL;
         if (title == NULL || title[0] == 0) return NULL;
 
         CPDF_Document* pDoc = (CPDF_Document*)document;
         CPDF_BookmarkTree tree(pDoc);
 
         FX_STRSIZE len = CFX_WideString::WStringLength(title);
         CFX_WideString wstr = CFX_WideString::FromUTF16LE(title, len);
@@ skipping 209 matching lines @@
         // Use UTF-16LE encoding
         CFX_ByteString bstr = text.UTF16LE_Encode();
         unsigned long len = bstr.GetLength();
         if (buffer != NULL && buflen >= len+2) {
                 FXSYS_memcpy(buffer, bstr.c_str(), len);
                 // use double zero as trailer
                 ((FX_BYTE*)buffer)[len] = ((FX_BYTE*)buffer)[len+1] = 0;
         }
         return len+2;
 }
-