Create ScopedTempDir, implement it on POSIX, and use it where appropriate.

util/test/scoped_temp_dir.h

Index: util/test/scoped_temp_dir.h
diff --git a/util/test/scoped_temp_dir.h b/util/test/scoped_temp_dir.h
new file mode 100644
index 0000000000000000000000000000000000000000..d355692f7795a0faffaee70b9bd086d5ef581f17
--- /dev/null
+++ b/util/test/scoped_temp_dir.h
@@ -0,0 +1,61 @@
+// Copyright 2014 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef CRASHPAD_UTIL_TEST_SCOPED_TEMP_DIR_
+#define CRASHPAD_UTIL_TEST_SCOPED_TEMP_DIR_
+
+#include "base/basictypes.h"
+#include "base/files/file_path.h"
+
+namespace crashpad {
+namespace test {
+
+//! \brief A RAII object that creates a temporary directory for testing.
+//!
+//! Upon construction, a temporary directory will be created. Failure to create
+//! the directory is fatal. On destruction, the directory and all its contents
+//! will be removed.
+class ScopedTempDir {
+ public:
+  ScopedTempDir();
+  ~ScopedTempDir();
+
+  //! \brief Returns the path of the temporary directory.
+  //!
+  //! \return The temporary directory path.
+  base::FilePath path() { return path_; }

[Mark Mentovai, 2014/12/31 05:51:09]

This should be const and can return a const&.

[Robert Sesek, 2015/01/02 17:34:08]

Done.

+
+ private:
+  //! \brief Creates the temporary directory and asserts success of the
+  //!     operation.
+  base::FilePath CreateTemporaryDirectory();

[Mark Mentovai, 2014/12/31 05:51:09]

This should be static. Remember to add “// static” to the .cc file.

[Robert Sesek, 2015/01/02 17:34:08]

Done.

+
+  //! \brief Removes all files and subdirectories at the given \a path,
+  //!     including the \a path itself.
+  //!
+  //! Failures should be recorded as gtest expectations.

[Mark Mentovai, 2014/12/31 05:51:09]

These are comments for the caller, not the implementer, so:

should → are.
as → by (or via).

[Robert Sesek, 2015/01/02 17:34:08]

Done.

+  //!
+  //! \param[in] path The path and its contents to delete. This must reference

[Mark Mentovai, 2014/12/31 05:51:09]

“The path and its contents to delete” doesn’t make great sense. “The path to
delete, along with its contents” may be better.

[Robert Sesek, 2015/01/02 17:34:08]

Done.

+  //!     a directory.
+  void RecursivelyDeleteTemporaryDirectory(const base::FilePath& path);

[Mark Mentovai, 2014/12/31 05:51:09]

So can this.

[Robert Sesek, 2015/01/02 17:34:08]

Done.

+
+  base::FilePath path_;

[Mark Mentovai, 2014/12/31 05:51:09]

Even this can be const.

[Robert Sesek, 2015/01/02 17:34:08]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(ScopedTempDir);
+};
+
+}  // namespace test
+}  // namespace crashpad
+
+#endif  // CRASHPAD_UTIL_TEST_SCOPED_TEMP_DIR_