Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: util/mac/xattr_test.cc

Issue 834693002: Create ScopedTempDir, implement it on POSIX, and use it where appropriate. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: For landing Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | util/test/scoped_temp_dir.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/mac/xattr.h" 15 #include "util/mac/xattr.h"
16 16
17 #include <fcntl.h> 17 #include <fcntl.h>
18 #include <sys/stat.h> 18 #include <sys/stat.h>
19 #include <unistd.h> 19 #include <unistd.h>
20 20
21 #include <limits> 21 #include <limits>
22 22
23 #include "base/files/scoped_file.h" 23 #include "base/files/scoped_file.h"
24 #include "base/posix/eintr_wrapper.h" 24 #include "base/posix/eintr_wrapper.h"
25 #include "base/strings/stringprintf.h" 25 #include "base/strings/stringprintf.h"
26 #include "gtest/gtest.h" 26 #include "gtest/gtest.h"
27 #include "util/test/errors.h" 27 #include "util/test/errors.h"
28 #include "util/test/scoped_temp_dir.h"
28 29
29 namespace crashpad { 30 namespace crashpad {
30 namespace test { 31 namespace test {
31 namespace { 32 namespace {
32 33
33 class Xattr : public testing::Test { 34 class Xattr : public testing::Test {
34 public: 35 protected:
35 // testing::Test: 36 // testing::Test:
36 37
37 void SetUp() override { 38 void SetUp() override {
38 path_ = base::FilePath( 39 path_ = temp_dir_.path().Append("xattr_file");
39 base::StringPrintf("/tmp/com.googlecode.crashpad.test.xattr.%d.%p",
40 getpid(), this));
41 // TODO(rsesek): This should use something like ScopedTempDir.
42 base::ScopedFD tmp(HANDLE_EINTR( 40 base::ScopedFD tmp(HANDLE_EINTR(
43 open(path_.value().c_str(), O_CREAT | O_TRUNC, 0644))); 41 open(path_.value().c_str(), O_CREAT | O_TRUNC, 0644)));
44 EXPECT_GE(tmp.get(), 0) << ErrnoMessage("open"); 42 EXPECT_GE(tmp.get(), 0) << ErrnoMessage("open");
45 } 43 }
46 44
47 void TearDown() override { 45 void TearDown() override {
48 EXPECT_EQ(0, unlink(path_.value().c_str())) << ErrnoMessage("unlink"); 46 EXPECT_EQ(0, unlink(path_.value().c_str())) << ErrnoMessage("unlink");
49 } 47 }
50 48
51 base::FilePath path() { return path_; } 49 const base::FilePath& path() const { return path_; }
52 50
53 private: 51 private:
52 ScopedTempDir temp_dir_;
54 base::FilePath path_; 53 base::FilePath path_;
55 }; 54 };
56 55
57 const char kKey[] = "com.google.crashpad.test"; 56 const char kKey[] = "com.google.crashpad.test";
58 57
59 TEST_F(Xattr, ReadNonExistentXattr) { 58 TEST_F(Xattr, ReadNonExistentXattr) {
60 std::string value; 59 std::string value;
61 EXPECT_FALSE(ReadXattr(path(), kKey, &value)); 60 EXPECT_FALSE(ReadXattr(path(), kKey, &value));
62 } 61 }
63 62
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 113
115 expected = std::numeric_limits<time_t>::max(); 114 expected = std::numeric_limits<time_t>::max();
116 EXPECT_TRUE(WriteXattrTimeT(path(), kKey, expected)); 115 EXPECT_TRUE(WriteXattrTimeT(path(), kKey, expected));
117 EXPECT_TRUE(ReadXattrTimeT(path(), kKey, &actual)); 116 EXPECT_TRUE(ReadXattrTimeT(path(), kKey, &actual));
118 EXPECT_EQ(expected, actual); 117 EXPECT_EQ(expected, actual);
119 } 118 }
120 119
121 } // namespace 120 } // namespace
122 } // namespace test 121 } // namespace test
123 } // namespace crashpad 122 } // namespace crashpad
OLDNEW
« no previous file with comments | « no previous file | util/test/scoped_temp_dir.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698