Issue 83463003: Fix gyptest-app for Xcode 5.0.2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83463003: Fix gyptest-app for Xcode 5.0.2 (Closed)

Created:
7 years, 1 month ago by sdefresne

Modified:
7 years ago

Reviewers:
Mark Mentovai

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

Fix gyptest-app for Xcode 5.0.2 With Xcode 5.0.0 or later, the DTSDKName of Info.plist is always set, even if SDKROOT is not defined in the Xcode project. BUG=381 R=mark@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1808

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -3 lines)			Patch
	M	pylib/gyp/xcode_emulation.py	View	1 2	4 chunks	+33 lines, -2 lines	0 comments	Download
	M	test/mac/gyptest-app.py	View	1	2 chunks	+14 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

sdefresne

On 2013/11/22 14:50:50, Mark Mentovai wrote: > Should ninja be updated too? Done, PTAL.

7 years, 1 month ago (2013-11-22 16:20:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r1808 (presubmit successful).