Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 834503002: Update stroke path to use rect returned from isRect (to fix trailing moveTo bug) (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update stroke path to use rect returned from isRect (to fix trailing moveTo bug) This basically recreates what was done in: https://codereview.chromium.org/16950021/ (add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular path has a trailing moveTo) with the addition of GM representation BUG=247770 Committed: https://skia.googlesource.com/skia/+/4f662e62cd44e302ef689fabdb2c0ae8d9471b02

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -18 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M gm/strokefill.cpp View 2 chunks +37 lines, -2 lines 0 comments Download
M include/core/SkPath.h View 1 2 chunks +18 lines, -2 lines 0 comments Download
M src/core/SkPath.cpp View 2 chunks +5 lines, -12 lines 0 comments Download
M src/core/SkStroke.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
robertphillips
5 years, 11 months ago (2014-12-29 21:44:28 UTC) #2
bsalomon
On 2014/12/29 21:44:28, robertphillips wrote: lgtm, but do we need both shortcut versions?
5 years, 11 months ago (2014-12-29 21:50:10 UTC) #3
robertphillips
On 2014/12/29 21:50:10, bsalomon wrote: > On 2014/12/29 21:44:28, robertphillips wrote: > > lgtm, but ...
5 years, 11 months ago (2014-12-29 21:52:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834503002/20001
5 years, 11 months ago (2014-12-29 21:57:35 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2014-12-29 22:06:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4f662e62cd44e302ef689fabdb2c0ae8d9471b02

Powered by Google App Engine
This is Rietveld 408576698