Flush stdout on calls to PrintString

Flush stdout on calls to PrintString

R=iposva@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=530

[Ivan Posva, 2011-10-18 20:52:43]

LGTM after addressing comment.

-Ivan

http://codereview.chromium.org/8345009/diff/1/runtime/bin/builtin.cc
File runtime/bin/builtin.cc (right):

http://codereview.chromium.org/8345009/diff/1/runtime/bin/builtin.cc#newcode9
runtime/bin/builtin.cc:9: #include <string>
I do not see a reason for changing which headers are to be included here.
Actually except for stdio.h all of the other system includes can be removed now.
Thanks!

[rchandia, 2011-10-18 21:05:28]

http://codereview.chromium.org/8345009/diff/1/runtime/bin/builtin.cc
File runtime/bin/builtin.cc (right):

http://codereview.chromium.org/8345009/diff/1/runtime/bin/builtin.cc#newcode9
runtime/bin/builtin.cc:9: #include <string>
On 2011/10/18 20:52:43, Ivan Posva wrote:
> I do not see a reason for changing which headers are to be included here.

Neither do I, but the presubmit script complained about <string.h> vs <string>

[rchandia, 2011-10-18 21:08:15]

Submitted r530

[Ivan Posva, 2011-10-18 21:31:53]

http://codereview.chromium.org/8345009/diff/1/runtime/bin/builtin.cc
File runtime/bin/builtin.cc (right):

http://codereview.chromium.org/8345009/diff/1/runtime/bin/builtin.cc#newcode9
runtime/bin/builtin.cc:9: #include <string>
On 2011/10/18 21:05:28, rchandia wrote:
> On 2011/10/18 20:52:43, Ivan Posva wrote:
> > I do not see a reason for changing which headers are to be included here.
> 
> Neither do I, but the presubmit script complained about <string.h> vs <string>

Agreed, but as I said it should not matter as all you need here is <stdio.h>
which is needed for fprintf and fflush.

[rchandia, 2011-10-18 21:42:57]

On 2011/10/18 21:31:53, Ivan Posva wrote:
> Agreed, but as I said it should not matter as all you need here is <stdio.h>
> which is needed for fprintf and fflush.

Is that a bug in the presubmit script then? It stubbornly requires
#include <strings>

$ git cl presubmit
Loaded authentication cookies from /home/rchandia/.codereview_upload_cookies
Running presubmit commit checks ...
/usr/local/google/users/rchandia/src/dart-src/dart/runtime/bin/builtin.cc:15: 
Add #include <string> for string  [build/include_what_you_use] [4]
Done processing
/usr/local/google/users/rchandia/src/dart-src/dart/runtime/bin/builtin.cc

** Presubmit ERRORS **
Failed cpplint check.

[Ivan Posva, 2011-10-18 21:46:20]

On 2011/10/18 21:42:57, rchandia wrote:
> On 2011/10/18 21:31:53, Ivan Posva wrote:
> > Agreed, but as I said it should not matter as all you need here is <stdio.h>
> > which is needed for fprintf and fflush.
> 
> Is that a bug in the presubmit script then? It stubbornly requires
> #include <strings>
> 
> $ git cl presubmit
> Loaded authentication cookies from /home/rchandia/.codereview_upload_cookies
> Running presubmit commit checks ...
> /usr/local/google/users/rchandia/src/dart-src/dart/runtime/bin/builtin.cc:15: 
> Add #include <string> for string  [build/include_what_you_use] [4]
> Done processing
> /usr/local/google/users/rchandia/src/dart-src/dart/runtime/bin/builtin.cc
> 
> ** Presubmit ERRORS **
> Failed cpplint check.

Sorry I missed that previously: If you have any identifier named "string" the
presubmit script expects you to include <strings>. We just avoid using that name
and use str instead for example. I had thought that we removed all of these in
the past, apparently not.

-Ivan