Issue 834483002: Fix bound returned by SkPath::isRect when the path contains a trailing moveTo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 834483002: Fix bound returned by SkPath::isRect when the path contains a trailing moveTo (Closed)

Created:
5 years, 11 months ago by robertphillips

Modified:
5 years, 11 months ago

Reviewers:
joshualitt

CC:
reviews_skia.org, reed1

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Fix bound returned by SkPath::isRect when the path contains a trailing moveTo Oddly enough this was fixed in: https://codereview.chromium.org/16950021/ (add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular path has a trailing moveTo) but was reverted here: https://skia.googlesource.com/skia/+/8fd160350ca5f57fbb1b2e03383c5778414a9b48 since it appeared to be crashing Chrome's trybots. I think it just fell through the cracks after that. If this sticks I will land a follow on patch for the stroke issue reported in the original bug (crbug.com/247770). BUG=247770, 445368 Committed: https://skia.googlesource.com/skia/+/fe7c427e3d1c2c98bce7a3fa0ae6b5864527f169

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -4 lines)			Patch
	M	src/core/SkPath.cpp	View		1 chunk	+13 lines, -4 lines	0 comments	Download
	M	tests/PathTest.cpp	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834483002/1

5 years, 11 months ago (2014-12-29 19:27:44 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2014-12-29 19:36:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fe7c427e3d1c2c98bce7a3fa0ae6b5864527f169