Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 834443004: remove declarative accessors (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

remove declarative accessors R=jochen@chromium.org BUG= Committed: https://crrev.com/a5aa01beec96441d9653f51c42dcfc388267e0e1 Cr-Commit-Position: refs/heads/master@{#25981}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : grokdump #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -1191 lines) Patch
M include/v8.h View 5 chunks +0 lines, -73 lines 0 comments Download
M src/api.h View 1 3 chunks +35 lines, -40 lines 0 comments Download
M src/api.cc View 4 chunks +0 lines, -155 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/lookup.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 3 chunks +0 lines, -115 lines 0 comments Download
M src/objects.cc View 1 2 3 7 chunks +3 lines, -227 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/objects-inl.h View 1 2 chunks +1 line, -9 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/test-declarative-accessors.cc View 1 chunk +0 lines, -302 lines 0 comments Download
M tools/v8heapconst.py View 1 2 3 chunks +220 lines, -205 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-07 15:18:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834443004/40001
5 years, 11 months ago (2015-01-07 15:25:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834443004/60001
5 years, 11 months ago (2015-01-07 16:09:17 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-07 16:37:35 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/a5aa01beec96441d9653f51c42dcfc388267e0e1 Cr-Commit-Position: refs/heads/master@{#25981}
5 years, 11 months ago (2015-01-07 16:38:00 UTC) #9
adamk
I was a bit surprised to see this go by. What's the background here? I ...
5 years, 11 months ago (2015-01-07 19:34:39 UTC) #11
dcarney
5 years, 11 months ago (2015-01-07 19:36:08 UTC) #12
Message was sent while issue was closed. 
On 2015/01/07 19:34:39, adamk wrote:
> I was a bit surprised to see this go by. What's the background here? I thought
> this was going to be the future API?

we've got a new future api in the works!

Powered by Google App Engine
This is Rietveld 408576698