Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: pkg/observe/lib/src/observable.dart

Issue 83443007: Remove use of deprecated mirror API from pkg/observe. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: ... Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/observe/lib/src/observable.dart
diff --git a/pkg/observe/lib/src/observable.dart b/pkg/observe/lib/src/observable.dart
index f798f4446f46c541c25579890e93a1f8ea859a54..35e91c8912e989ececca48a1e89f0f74c384c686 100644
--- a/pkg/observe/lib/src/observable.dart
+++ b/pkg/observe/lib/src/observable.dart
@@ -82,8 +82,11 @@ abstract class Observable {
// actually includes this mixin. While perhaps too inclusive, it lets us
// avoid complex logic that walks "with" and "implements" clauses.
for (var type = mirror.type; type != objectType; type = type.superclass) {
- for (var field in type.variables.values) {
- if (field.isFinal || field.isStatic || field.isPrivate) continue;
+ for (var field in type.declarations.values) {
+ if (field is! VariableMirror ||
+ field.isFinal ||
+ field.isStatic ||
+ field.isPrivate) continue;
for (var meta in field.metadata) {
if (meta.reflectee is ObservableProperty) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698